From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161030AbbENPz5 (ORCPT ); Thu, 14 May 2015 11:55:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45791 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698AbbENPzi (ORCPT ); Thu, 14 May 2015 11:55:38 -0400 Date: Thu, 14 May 2015 17:55:34 +0200 From: "Luis R. Rodriguez" To: "Elliott, Robert (Server Storage)" , bp@suse.de Cc: "Luis R. Rodriguez" , "mingo@elte.hu" , "tglx@linutronix.de" , "hpa@zytor.com" , "plagnioj@jcrosoft.com" , "tomi.valkeinen@ti.com" , "daniel.vetter@intel.com" , "airlied@linux.ie" , "dledford@redhat.com" , "awalls@md.metrocast.net" , "syrjala@sci.fi" , "luto@amacapital.net" , "mst@redhat.com" , "cocci@systeme.lip6.fr" , "linux-kernel@vger.kernel.org" , Juergen Gross , Daniel Vetter , Dave Airlie , Bjorn Helgaas , "x86@kernel.org" Subject: Re: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends Message-ID: <20150514155534.GV23057@wotan.suse.de> References: <1430425520-22275-1-git-send-email-mcgrof@do-not-panic.com> <1430425520-22275-2-git-send-email-mcgrof@do-not-panic.com> <94D0CD8314A33A4D9D801C0FE68B40295A8E3CFF@G4W3202.americas.hpqcorp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295A8E3CFF@G4W3202.americas.hpqcorp.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2015 at 03:36:15AM +0000, Elliott, Robert (Server Storage) wrote: > > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > > owner@vger.kernel.org] On Behalf Of Luis R. Rodriguez > > Sent: Thursday, April 30, 2015 3:25 PM > > Subject: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends > > > ... > > - printk(KERN_ERR "%s:%d map pfn expected mapping > > type %s" > > - " for [mem %#010Lx-%#010Lx], got %s\n", > > - current->comm, current->pid, > > - cattr_name(want_pcm), > > - (unsigned long long)paddr, > > - (unsigned long long)(paddr + size - 1), > > - cattr_name(pcm)); > > + pr_err("%s:%d map pfn expected mapping type %s" > > + " for [mem %#010Lx-%#010Lx], got %s\n", > > Since the patch joins some other print format strings split across > lines (which checkpatch allows), you might want to join this one too. > > ... > > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c > ... > > failure: > > - printk(KERN_INFO "%s:%d conflicting memory types " > > + pr_info("%s:%d conflicting memory types " > > "%Lx-%Lx %s<->%s\n", current->comm, current->pid, start, > > end, cattr_name(found_type), cattr_name(match->type)); > > and that one. I have adjusted this. Boris, would you like a v6 re-spin on this series? Or just this patch, or anthing else? FWIW since I keep having to re-do patches / rebase after a while and the entire kill-mtrr series is large with tons of parts I've set out a tree with all pending mtrr changes. The kill-mtrr-v5-20150514 can be used: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git When needed I'll just fetch linux-next and rebase --onto that day's origin/master. Luis