From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965107AbbENT3H (ORCPT ); Thu, 14 May 2015 15:29:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:40290 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964826AbbENT3E (ORCPT ); Thu, 14 May 2015 15:29:04 -0400 Date: Thu, 14 May 2015 20:28:47 +0100 From: Mark Brown To: Lars-Peter Clausen Cc: "Maciej S. Szmigiero" , alsa-devel@alsa-project.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Brian Austin , Bard Liao , Oder Chiou , Wolfram Sang , linux-kernel@vger.kernel.org, Fabio Estevam Message-ID: <20150514192847.GV2761@sirena.org.uk> References: <554E8634.2010008@maciej.szmigiero.name> <20150512175807.GL3066@sirena.org.uk> <5553BAB4.3040209@maciej.szmigiero.name> <20150514175351.GQ2761@sirena.org.uk> <5554ED71.4040608@metafoo.de> <20150514191031.GS2761@sirena.org.uk> <5554F65F.7090004@metafoo.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B4kTqtjDNMSIbfiv" Content-Disposition: inline In-Reply-To: <5554F65F.7090004@metafoo.de> X-Cookie: 13. ... r-q1 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: codecs-ac97: make selectable in config X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --B4kTqtjDNMSIbfiv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 14, 2015 at 09:24:15PM +0200, Lars-Peter Clausen wrote: > On 05/14/2015 09:10 PM, Mark Brown wrote: > >Does the select from SND_SOC_AC97_BUS actually happen if it is selected > >by SND_SOC_ALL_CODECS? That's the issue, if it works now it's a > >relatively recent thing. > I'm not sure I fully understand what you mean. > The Kconfig entry for the CODEC has no 'depends on'. It does a 'select > SND_SOC_AC97_BUS', which means all built time dependencies are pulled in > this way. So if SND_SOC_ALL_CODECS selects the CODEC unconditionally that > should work fine, since no dependencies are bypassed. No, it's not just dependencies but also selects that get ignored (or used to anyway like I say) - a select just forces the symbol on. --B4kTqtjDNMSIbfiv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVVPduAAoJECTWi3JdVIfQ/eYH/ijmFCdHVhYrarYNrn0SGB8y BdO62i6ekx8hTOYtZ/jYmNMaY6j0FMIdHuIF9Xgnl1lQIeJ2xF4iZg959B0tjfGf /pUjot7+gyJkYD9gIkAbVMmv/xB0PP9YOuBlKQVwUcxRsdEPNGI73S7aLXYJv85Q GCZw5PiPRtWtrhhjBkd5SY/fx5RgFCBlkOaSUOmaBxp83AVB3n2o3gsf4FxC59eO anE3r2cXJjPuMsKyAyE45MwZyG0kQnOBv+W8VnOpcMIAUefZU49Bjx4NDg4wyY9R 3R18UAH31NkbFKSq8hs46UFPHd7ePAUIEIocRkG9GNomJDJEu8oGiuBBHoJuSMs= =t0jE -----END PGP SIGNATURE----- --B4kTqtjDNMSIbfiv--