From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422745AbbENVuv (ORCPT ); Thu, 14 May 2015 17:50:51 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42607 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1422689AbbENVut (ORCPT ); Thu, 14 May 2015 17:50:49 -0400 Date: Thu, 14 May 2015 23:50:47 +0200 From: Alexandre Belloni To: Andrew Morton Cc: Arnd Bergmann , Alessandro Zummo , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: pfc8563: fix uninitialized variable warning Message-ID: <20150514215047.GE3338@piout.net> References: <2293546.ekQV1ek12O@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2293546.ekQV1ek12O@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On 12/05/2015 at 23:27:02 +0200, Arnd Bergmann wrote : > Gcc is unable to prove that alm_pending is always initialized > when it is used, so it prints a harmless warning: > > drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_probe': > drivers/rtc/rtc-pcf8563.c:449:5: warning: 'alm_pending' may be used uninitialized in this function [-Wmaybe-uninitialized] > > This uses the same conditional expression that is used inside of > the pcf8563_get_alarm_mode() function, to help gcc figure it out > and shut up that warning, and make the ARM defconfigs build again > with no warnings. > > Signed-off-by: Arnd Bergmann > Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time") > Can you send that fix to Linus for the next 4.1 rc? You can add my Acked-by: Alexandre Belloni I hope that will be the last one :) Thanks! -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com