From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945969AbbEOC6m (ORCPT ); Thu, 14 May 2015 22:58:42 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:17325 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1423371AbbEOC6k (ORCPT ); Thu, 14 May 2015 22:58:40 -0400 Date: Thu, 14 May 2015 22:58:57 -0400 From: Steven Rostedt To: Philipp Zabel Cc: LKML , Kamil Debski , Mauro Carvalho Chehab , Chris Wilson Subject: Re: [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING Message-ID: <20150514225857.27dc5965@grimm.local.home> In-Reply-To: <20150514225250.70d2902f@grimm.local.home> References: <20150514225250.70d2902f@grimm.local.home> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 May 2015 22:52:50 -0400 Steven Rostedt wrote: > TRACE_SYSTEM_STRING is used internally to the TRACE_EVENT system. It > should not be defined by tracepoint files. I'm not even sure who > started that (I hope it wasn't me!) According to git history, that define first showed up in commit 1c5d22f76dc721f3acb7a3dadc657a221e487fb7 Author: Chris Wilson Date: Tue Aug 25 11:15:50 2009 +0100 drm/i915: Add tracepoints And it must have spread with cut and paste. Now I need to start administering a vaccine to keep developers from catching it! -- Steve > > Reported-by: kbuild test robot > Signed-off-by: Steven Rostedt --- > diff --git a/drivers/media/platform/coda/trace.h b/drivers/media/platform/coda/trace.h > index d1d06cbd1f6a..781bf7286d53 100644 > --- a/drivers/media/platform/coda/trace.h > +++ b/drivers/media/platform/coda/trace.h > @@ -9,8 +9,6 @@ > > #include "coda.h" > > -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) > - > TRACE_EVENT(coda_bit_run, > TP_PROTO(struct coda_ctx *ctx, int cmd), >