From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945963AbbEOShO (ORCPT ); Fri, 15 May 2015 14:37:14 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34349 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933364AbbEOShJ (ORCPT ); Fri, 15 May 2015 14:37:09 -0400 Date: Fri, 15 May 2015 11:37:07 -0700 From: Stephen Boyd To: Ricky Liang Cc: Mike Turquette , Matthias Brugger , James Liao , Sascha Hauer , Henry Chen , "open list:COMMON CLK FRAMEWORK" , open list , "moderated list:ARM/Mediatek SoC..." , "moderated list:ARM/Mediatek SoC..." Subject: Re: [PATCH] clk: mediatek: Initialize clk flags Message-ID: <20150515183707.GM31753@codeaurora.org> References: <1431670969-1996-1-git-send-email-jcliang@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431670969-1996-1-git-send-email-jcliang@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/15, Ricky Liang wrote: > diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c > index 66154ca..72fe307 100644 > --- a/drivers/clk/mediatek/clk-pll.c > +++ b/drivers/clk/mediatek/clk-pll.c > @@ -289,6 +289,7 @@ static struct clk *mtk_clk_register_pll(const struct mtk_pll_data *data, > init.ops = &mtk_pll_ops; > init.parent_names = &parent_name; > init.num_parents = 1; > + init.flags = data->flags; Wrong? It looks like plls[] in drivers/clk/mediatek/clk-mt8135.c is putting mtk specific clock flags in this structure member. How about initializing the structure to { } instead? That way if we ever add more structure members we don't have to detect the landmine laid here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project