From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbbEQQPZ (ORCPT ); Sun, 17 May 2015 12:15:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52876 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbbEQQPN (ORCPT ); Sun, 17 May 2015 12:15:13 -0400 Date: Sun, 17 May 2015 09:15:11 -0700 From: Kenneth Westfield To: Srinivas Kandagatla Cc: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Kenneth Westfield , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 00/13] ASoC: qcom: add support to apq8016 audio Message-ID: <20150517161510.GC10901@kwestfie-linux.qualcomm.com> Mail-Followup-To: Srinivas Kandagatla , Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org> <1431779462-1732-1-git-send-email-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431779462-1732-1-git-send-email-srinivas.kandagatla@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 16, 2015 at 05:31:02AM -0700, Srinivas Kandagatla wrote: > Thankyou for reviewing the v1 patches, here is the v2 patchset after > incorporating review comments and testing on Storm Board. > This patchset adds apq8016 audio support into lpass driver. Existing > Lpass driver can not be used as-it-is for apq8016 as it contains code > specific to ipq806x. Also the driver only supports single i2s port, > single dma channel and single bitclk control. > > APQ8016 has 4 MI2S( Primary, Secondary, Tertiary, Quaternary) which can be > routed > to internal wcd codec or external codecs. This routing is controlled by 2 > mux > registers. > > This patch series firstly re-organizes the lpass driver such that the SOC > specific bits are moved away from the driver. And secondly the SOC > specifics > are now passed as lpass variant data which would include various register > offsets, dma channel allocations and SOC specific clock handling. > > Finally the last few patchs add apq8016 lpass and machine driver. > > All these patches are tested for HDMI audio via adv7533 bridge and Analog > audio > on APQ8016-SBC, msm8916-mtp boards and Kenneth tested this patchset on > ipq806x Storm board too. Other than the two comments on patches 5 and 6, everything else looks fine to me. Acked-by: Kenneth Westfield -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project