From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jagan Teki <jteki@openedev.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Subject: Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy()
Date: Sun, 17 May 2015 16:27:10 -0700 [thread overview]
Message-ID: <20150517232710.GA27330@kroah.com> (raw)
In-Reply-To: <1431896221-7599-1-git-send-email-jteki@openedev.com>
On Mon, May 18, 2015 at 02:27:01AM +0530, Jagan Teki wrote:
> This patch fixes to use ether_addr_copy() instead of memcpy()
>
> Encounter this by applying checkpatch.pl against this file:
> WARNING: Prefer ether_addr_copy() over memcpy()
> if the Ethernet addresses are __aligned(2)
>
> Signed-off-by: Jagan Teki <jteki@openedev.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
> ---
> drivers/staging/rtl8712/os_intfs.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
You need to prove that the addresses are aligned, please do so in the
changelog entry.
next prev parent reply other threads:[~2015-05-17 23:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 20:57 Jagan Teki
2015-05-17 23:27 ` Greg Kroah-Hartman [this message]
2015-05-18 0:09 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150517232710.GA27330@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=jteki@openedev.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome