From: Christoph Hellwig <hch@infradead.org>
To: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com, Jens Axboe <axboe@kernel.dk>,
Joe Thornber <ejt@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH for-4.2 04/14] block: factor out blkdev_issue_discard_async
Date: Mon, 18 May 2015 01:27:56 -0700 [thread overview]
Message-ID: <20150518082756.GB5439@infradead.org> (raw)
In-Reply-To: <1431637512-64245-5-git-send-email-snitzer@redhat.com>
On Thu, May 14, 2015 at 05:05:02PM -0400, Mike Snitzer wrote:
> From: Joe Thornber <ejt@redhat.com>
>
> Useful for callers who wish to manage the async completion of discard(s)
> without explicitly blocking waiting for completion.
>
> blkdev_issue_discard() is updated to call blkdev_issue_discard_async()
> and DM thinp will make use of blkdev_issue_discard_async() in the
> upcoming "dm thin: range discard support" commit.
I think this is the wrong level of interface. I think dm should just
submit the bios directly, which will also allow it to use bio_chain
properly instead of needing the inc_remaining hack. Instead export
helpers that properly split up the discard chunk sectors without
touching the bio itself. And with bio split on demand work even
that will hopefully go away soon.
next prev parent reply other threads:[~2015-05-18 8:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 21:04 [PATCH for-4.2 00/14] block, dm: first batch of changes for 4.2 Mike Snitzer
2015-05-14 21:04 ` [PATCH for-4.2 01/14] block: remove management of bi_remaining when restoring original bi_end_io Mike Snitzer
2015-05-18 7:22 ` Jan Kara
2015-05-18 13:13 ` Mike Snitzer
2015-05-18 15:36 ` Jan Kara
2015-05-18 15:59 ` Mike Snitzer
2015-05-18 20:40 ` [PATCH for-4.2 v2 " Mike Snitzer
2015-05-19 6:28 ` Christoph Hellwig
2015-05-19 7:20 ` Jan Kara
2015-05-18 8:24 ` [dm-devel] [PATCH for-4.2 " Christoph Hellwig
2015-05-18 13:20 ` Mike Snitzer
2015-05-14 21:05 ` [PATCH for-4.2 02/14] block: remove export for blk_queue_bio Mike Snitzer
2015-05-14 21:05 ` [PATCH for-4.2 03/14] block, dm: don't copy bios for request clones Mike Snitzer
2015-05-14 21:05 ` [PATCH for-4.2 04/14] block: factor out blkdev_issue_discard_async Mike Snitzer
2015-05-18 8:27 ` Christoph Hellwig [this message]
2015-05-18 13:32 ` Mike Snitzer
2015-05-18 16:17 ` [dm-devel] " Christoph Hellwig
2015-05-18 19:18 ` Mike Snitzer
2015-05-19 8:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518082756.GB5439@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®