From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbbERFKF (ORCPT ); Mon, 18 May 2015 01:10:05 -0400 Received: from ozlabs.org ([103.22.144.67]:44793 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbERFKA (ORCPT ); Mon, 18 May 2015 01:10:00 -0400 Date: Mon, 18 May 2015 15:09:57 +1000 From: Anton Blanchard To: Anshuman Khandual Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, mikey@neuling.org, shuahkh@osg.samsung.com Subject: Re: [PATCH V3 09/13] selftests, powerpc: Add test for DSCR value inheritence across fork Message-ID: <20150518150957.4c228ac4@kryten> In-Reply-To: <1428654612-23539-10-git-send-email-khandual@linux.vnet.ibm.com> References: <1428654612-23539-1-git-send-email-khandual@linux.vnet.ibm.com> <1428654612-23539-10-git-send-email-khandual@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anshuman, Thanks for getting these testcases into the kernel. > This patch adds a test to verify that the changed DSCR value inside > any process would be inherited to it's child process across the fork > system call. One issue I do notice (a bug in my original test cases too), is that we don't restore the DSCR on exit. I'm not sure we need to go to the trouble of saving and restoring it, but we should at least get it back to 0 when done. Also a tiny nit, no need for a newline in perror(): open() failed : Permission denied With those changes you can add: Signed-off-by: Anton Blanchard to the patches based on my testcases. Anton