From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbbESHa0 (ORCPT ); Tue, 19 May 2015 03:30:26 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:57069 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbbESHaV (ORCPT ); Tue, 19 May 2015 03:30:21 -0400 Date: Tue, 19 May 2015 15:30:12 +0800 From: Herbert Xu To: Jaegeuk Kim Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, ecryptfs@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] crypto: allow to assign gfp_t for __crypto_alloc_tfm Message-ID: <20150519073012.GA29030@gondor.apana.org.au> References: <1432014416-39326-1-git-send-email-jaegeuk@kernel.org> <20150519054945.GA28060@gondor.apana.org.au> <20150519062430.GA39588@jaegeuk-mac02.hsd1.ca.comcast.net> <20150519063211.GA28347@gondor.apana.org.au> <20150519065812.GA40012@jaegeuk-mac02.hsd1.ca.comcast.net> <20150519065929.GA28610@gondor.apana.org.au> <20150519071317.GB40012@jaegeuk-mac02.hsd1.ca.comcast.net> <20150519071521.GA28862@gondor.apana.org.au> <20150519072740.GA40281@jaegeuk-mac02.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519072740.GA40281@jaegeuk-mac02.hsd1.ca.comcast.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2015 at 12:27:40AM -0700, Jaegeuk Kim wrote: > > So, IMHO, it can consume memory too much, since tfm should be allocated for > every inodes and be alive until inode eviction. Are you sure this is a real problem? Have you actually looked at how much memory it consumes? > Apart from giving GFP_NOFS, do you mean that it is a wrong approach? Allocating the tfm and setting a key on the data path is not acceptable. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt