From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932076AbbESMEb (ORCPT ); Tue, 19 May 2015 08:04:31 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46454 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752884AbbESME2 (ORCPT ); Tue, 19 May 2015 08:04:28 -0400 Date: Tue, 19 May 2015 15:04:19 +0300 From: Dan Carpenter To: "Nicholas A. Bellinger" Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch -next] target: double locking typo in core_clear_lun_from_tpg() Message-ID: <20150519120419.GA12107@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We accidentally deadlock instead of unlocking. Fixes: 08d20ff62cde ('target: Acquire lun_entry_mutex during core_disable_device_list_for_node') Signed-off-by: Dan Carpenter diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 2f4c8fa..20618df 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c @@ -433,7 +433,7 @@ void core_clear_lun_from_tpg(struct se_lun *lun, struct se_portal_group *tpg) core_disable_device_list_for_node(lun, deve, nacl, tpg); } - mutex_lock(&nacl->lun_entry_mutex); + mutex_unlock(&nacl->lun_entry_mutex); } mutex_unlock(&tpg->acl_node_mutex); }