From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933390AbbESOvU (ORCPT ); Tue, 19 May 2015 10:51:20 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:37539 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932324AbbESOvB (ORCPT ); Tue, 19 May 2015 10:51:01 -0400 Date: Tue, 19 May 2015 16:53:40 +0200 From: Michal Hocko To: Johannes Weiner Cc: Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Tejun Heo , cgroups@vger.kernel.org Subject: Re: [PATCH] mm, memcg: Optionally disable memcg by default using Kconfig Message-ID: <20150519145340.GI6203@dhcp22.suse.cz> References: <20150519104057.GC2462@suse.de> <20150519141807.GA9788@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150519141807.GA9788@cmpxchg.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 19-05-15 10:18:07, Johannes Weiner wrote: > CC'ing Tejun and cgroups for the generic cgroup interface part > > On Tue, May 19, 2015 at 11:40:57AM +0100, Mel Gorman wrote: [...] > > /usr/src/linux-4.0-vanilla/mm/memcontrol.c 6.6441 395842 > > mem_cgroup_try_charge 2.950% 175781 > > Ouch. Do you have a way to get the per-instruction breakdown of this? > This function really isn't doing much. I'll try to reproduce it here > too, I haven't seen such high costs with pft in the past. > > > try_charge 0.150% 8928 > > get_mem_cgroup_from_mm 0.121% 7184 Indeed! try_charge + get_mem_cgroup_from_mm which I would expect to be the biggest consumers here are below 10% of the mem_cgroup_try_charge. Other than that the function doesn't do much else than some flags queries and css_put... Do you have the full trace? Sorry for a stupid question but do inlines from other header files get accounted to memcontrol.c? [...] -- Michal Hocko SUSE Labs