From: David Miller <davem@davemloft.net>
To: mkubecek@suse.cz
Cc: nicolas.dichtel@6wind.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
roopa@cumulusnetworks.com
Subject: Re: [PATCH net v3 0/2] IPv6 ECMP route add/replace fixes
Date: Wed, 20 May 2015 12:03:40 -0400 (EDT) [thread overview]
Message-ID: <20150520.120340.894954416645925582.davem@davemloft.net> (raw)
In-Reply-To: <cover.1431974706.git.mkubecek@suse.cz>
From: Michal Kubecek <mkubecek@suse.cz>
Date: Mon, 18 May 2015 20:53:50 +0200 (CEST)
> (1) When adding a nexthop of a multipath route fails (e.g. because of a
> conflict with an existing route), we are supposed to delete nexthops
> already added. However, currently we try to also delete all nexthops we
> haven't even tried to add yet so that a "ip route add" command can
> actually remove pre-existing routes if it fails.
>
> (2) Attempt to replace a multipath route results in a broken siblings
> linked list. Following commands (like "ip route del") can then either
> follow a link into freed memory or end in an infinite loop (if the slab
> object has been reused).
>
> v2: fix an omission in first patch
>
> v3: change the semantics of replace operation to better match IPv4
Series applied, thanks.
next prev parent reply other threads:[~2015-05-20 16:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 9:50 [PATCH net " Michal Kubecek
2015-05-13 9:50 ` [PATCH net 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-13 12:28 ` Nicolas Dichtel
2015-05-13 12:49 ` Michal Kubecek
2015-05-13 13:30 ` roopa
2015-05-13 20:06 ` Michal Kubecek
2015-05-13 19:59 ` [PATCH net v2 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-13 19:59 ` [PATCH net v2 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-14 18:54 ` Nicolas Dichtel
2015-05-13 19:59 ` [PATCH net v2 2/2] ipv6: fix ECMP route replacement Michal Kubecek
2015-05-14 18:58 ` Nicolas Dichtel
2015-05-14 21:49 ` Michal Kubecek
2015-05-15 8:51 ` Michal Kubecek
2015-05-15 16:12 ` David Miller
2015-05-15 17:41 ` Michal Kubecek
2015-05-16 21:18 ` David Miller
2015-05-18 18:53 ` [PATCH net v3 0/2] IPv6 ECMP route add/replace fixes Michal Kubecek
2015-05-18 18:53 ` [PATCH net v3 1/2] ipv6: do not delete previously existing ECMP routes if add fails Michal Kubecek
2015-05-18 18:54 ` [PATCH net v3 2/2] ipv6: fix ECMP route replacement Michal Kubecek
2015-05-19 20:51 ` David Miller
2015-05-20 8:56 ` Nicolas Dichtel
2015-05-20 16:03 ` David Miller [this message]
2015-05-13 9:50 ` [PATCH net " Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520.120340.894954416645925582.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=roopa@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®