From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbbETX2L (ORCPT ); Wed, 20 May 2015 19:28:11 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:33484 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882AbbETX2I (ORCPT ); Wed, 20 May 2015 19:28:08 -0400 Date: Wed, 20 May 2015 16:27:59 -0700 From: Brian Norris To: Julian Calaby Cc: Michal Suchanek , linux-sunxi , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , David Woodhouse , Marek Vasut , Huang Shijie , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Ben Hutchings , Alison Chaiken , Mika Westerberg , Bean Huo =?utf-8?B?6ZyN5paM5paMIChiZWFuaHVvKQ==?= , "grmoore@altera.com" , devicetree , "linux-kernel@vger.kernel.org" , linux-mtd@lists.infradead.org Subject: Re: [linux-sunxi] [PATCH 3/3] MTD: m25p80: Add option to limit SPI transfer size. Message-ID: <20150520232759.GW11598@ld-irv-0074> References: <3b0c112672f364452e80c333048161eaffb655db.1430403750.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 01, 2015 at 12:58:52AM +1000, Julian Calaby wrote: > On Thu, Apr 30, 2015 at 11:46 PM, Michal Suchanek wrote: > > My SPI driver does not support DMA so sizes larger than 64 bytes return > > an error. Add an option to limit transfer size so m25p80 can be used > > with reduced speed with such controller. > > I suspect that this will be rejected as the maximum transfer size is a > property of the SPI controller, not the device and should be exported > to the device driver from the controller, not specified in the > device's binding. Absolutely correct. This does not belong in the device tree. Brian