From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: pebolle@tiscali.nl, andreas.steffen@strongswan.org,
tytso@mit.edu, sandyinchina@gmail.com,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 3/5] crypto: drbg - add async seeding operation
Date: Thu, 21 May 2015 14:56:43 +0800 [thread overview]
Message-ID: <20150521065643.GA21490@gondor.apana.org.au> (raw)
In-Reply-To: <1887173.hBZISiAer1@tauon>
On Thu, May 21, 2015 at 08:53:13AM +0200, Stephan Mueller wrote:
>
> Thank you for pointing that out - I have seen that too. But the crux is that
> when using wait_event, the cancel function to serialize the destruction code
> path will *not* return at all, even when the async callback function completed
> successfully. Hence the choice for wait_event_interruptible
Why is that? It should return when the pool is initialised and
your work completes. If it does not then that means either the
pool isn't initialising or somehow your code is racy and getting
stuck.
If it's racy then wait_event_interruptible is just hiding the
real problem.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2015-05-21 6:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 20:02 [PATCH v9 0/5] Seeding DRBG with more entropy Stephan Mueller
2015-05-20 20:02 ` [PATCH v9 1/5] random: Blocking API for accessing nonblocking_pool Stephan Mueller
2015-05-20 20:03 ` [PATCH v9 2/5] crypto: drbg - prepare for async seeding Stephan Mueller
2015-05-20 20:03 ` [PATCH v9 3/5] crypto: drbg - add async seeding operation Stephan Mueller
2015-05-20 21:44 ` Herbert Xu
2015-05-21 6:10 ` Stephan Mueller
2015-05-21 6:36 ` Herbert Xu
2015-05-21 6:53 ` Stephan Mueller
2015-05-21 6:56 ` Herbert Xu [this message]
2015-05-21 7:55 ` Stephan Mueller
2015-05-21 8:19 ` random: Wake up all getrandom(2) callers when pool is ready Herbert Xu
2015-05-21 8:36 ` Stephan Mueller
2015-05-21 19:17 ` Theodore Ts'o
2015-05-22 0:23 ` Herbert Xu
2015-05-20 20:04 ` [PATCH v9 4/5] crypto: drbg - use Jitter RNG to obtain seed Stephan Mueller
2015-05-20 20:04 ` [PATCH v9 5/5] crypto: add jitterentropy RNG Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521065643.GA21490@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andreas.steffen@strongswan.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=sandyinchina@gmail.com \
--cc=smueller@chronox.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®