From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] rcu: Deinline rcu_read_lock_sched_held() if DEBUG_LOCK_ALLOC
Date: Thu, 21 May 2015 09:09:43 -0400 [thread overview]
Message-ID: <20150521090943.0e01ed05@gandalf.local.home> (raw)
In-Reply-To: <20150521125224.GK6776@linux.vnet.ibm.com>
On Thu, 21 May 2015 05:52:24 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> On Thu, May 21, 2015 at 12:04:07PM +0200, Denys Vlasenko wrote:
> > DEBUG_LOCK_ALLOC=y is not a production setting, but it is
> > not very unusual either. Many developers routinely
> > use kernels built with it enabled.
> >
> > Apart from being selected by hand, it is also auto-selected by
> > PROVE_LOCKING "Lock debugging: prove locking correctness" and
> > LOCK_STAT "Lock usage statistics" config options.
> > LOCK STAT is necessary for "perf lock" to work.
> >
> > I wouldn't spend too much time optimizing it, but this particular
> > function has a very large cost in code size: when it is deinlined,
> > code size decreases by 830,000 bytes:
> >
> > text data bss dec hex filename
> > 85674192 22294776 20627456 128596424 7aa39c8 vmlinux.before
> > 84837612 22294424 20627456 127759492 79d7484 vmlinux
> >
> > (with this config: http://busybox.net/~vda/kernel_config)
>
> OK, I'll bite... I do see the numbers above, but is this really a
> problem for anyone? As you say, DEBUG_LOCK_ALLOC=y is not a production
> setting.
>
Correct, and because it's not a production setting it should be fine as
a call and not a static inline. The i$ hit probably neglects the saving
of it being inlined too.
It's not a big deal either way, but it may make building the kernel a
bit faster ;-)
-- Steve
next prev parent reply other threads:[~2015-05-21 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:04 Denys Vlasenko
2015-05-21 12:52 ` Paul E. McKenney
2015-05-21 13:09 ` Steven Rostedt [this message]
2015-05-21 13:25 ` Paul E. McKenney
2015-05-21 13:41 ` Steven Rostedt
2015-05-21 13:45 ` Steven Rostedt
2015-05-21 15:09 ` Denys Vlasenko
2015-05-21 15:26 ` Paul E. McKenney
2015-05-21 21:53 ` Denys Vlasenko
2015-05-26 15:18 ` Paul E. McKenney
2015-05-26 15:37 ` Steven Rostedt
2015-05-26 15:47 ` Denys Vlasenko
2015-05-26 15:51 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521090943.0e01ed05@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dvlasenk@redhat.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®