From: Al Viro <viro@ZenIV.linux.org.uk>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: akpm@linux-foundation.org, dhowells@redhat.com, fabf@skynet.be,
linux-kernel@vger.kernel.org,
"v.narang@samsung.com" <v.narang@samsung.com>
Subject: Re: [EDT] [PATCH] devpts/inode.c : Fix Possible dentry NULL dereference
Date: Thu, 21 May 2015 12:12:38 +0100 [thread overview]
Message-ID: <20150521111238.GB7232@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1817342376.533191432204130151.JavaMail.weblogic@ep2mlwas07b>
On Thu, May 21, 2015 at 10:28:52AM +0000, Maninder Singh wrote:
> Subject: [PATCH 1/1] devpts/inode.c : Fix Possible dentry NULL dereference
>
> Issue reported by static tool Analyzer (Prevent).
> d_find_alias can return NULL to deentry, Thus we need NULL check
> before calling d_delete(dentry)
No, we do not. That inode must have come from devpts_pty_new() and it
wouldn't have made it out of there without having a dentry attached to
it (and pinned).
NAK.
prev parent reply other threads:[~2015-05-21 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 10:28 Maninder Singh
2015-05-21 10:42 ` Richard Weinberger
2015-05-21 11:12 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521111238.GB7232@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome