From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756646AbbEUQdl (ORCPT ); Thu, 21 May 2015 12:33:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56166 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756173AbbEUQdj (ORCPT ); Thu, 21 May 2015 12:33:39 -0400 Date: Thu, 21 May 2015 18:33:36 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bsd@redhat.com Subject: Re: [PATCH 08/12] KVM: x86: save/load state on SMM switch Message-ID: <20150521163335.GA31171@potion.brq.redhat.com> References: <1431084034-8425-1-git-send-email-pbonzini@redhat.com> <1431084034-8425-9-git-send-email-pbonzini@redhat.com> <20150521162036.GA31183@potion.brq.redhat.com> <555E061C.1020705@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <555E061C.1020705@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-05-21 18:21+0200, Paolo Bonzini: > On 21/05/2015 18:20, Radim Krčmář wrote: > > > >> > + set_desc_base(&desc, get_smstate(u32, smbase, offset + 8)); > >> > + set_desc_limit(&desc, get_smstate(u32, smbase, offset + 4)); > >> > + rsm_set_desc_flags(&desc, get_smstate(u32, smbase, offset)); > > (There wan't a layout where this would be right, so we could save the > > shifting of those flags in 64 bit mode. Intel P6 was close, and they > > had only 2 bytes for access right, which means they weren't shifted.) > > Check the AMD architecture manual. I must be blind, is there more than Table 10-2? (And according to ADM manual, we are overwriting GDT and IDT base at offset 0xff88 and 0xff94 with ES and CS data, so it's not the best reference for this case ...)