From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932198AbbEUSuu (ORCPT ); Thu, 21 May 2015 14:50:50 -0400 Received: from mga09.intel.com ([134.134.136.24]:49548 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755718AbbEUSut (ORCPT ); Thu, 21 May 2015 14:50:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,471,1427785200"; d="scan'208";a="575027761" Date: Thu, 21 May 2015 11:50:48 -0700 From: Andi Kleen To: Sukadev Bhattiprolu Cc: mingo@redhat.com, Michael Ellerman , Jiri Olsa , Arnaldo Carvalho de Melo , Paul Mackerras , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] perf: Use pmu_events_map table to create event aliases Message-ID: <20150521185048.GF7484@tassilo.jf.intel.com> References: <1432080130-6678-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432080130-6678-4-git-send-email-sukadev@linux.vnet.ibm.com> <20150520235826.GB7484@tassilo.jf.intel.com> <20150521001935.GD11568@us.ibm.com> <20150521025653.GC7484@tassilo.jf.intel.com> <20150521050204.GA20360@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150521050204.GA20360@us.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 20, 2015 at 10:02:04PM -0700, Sukadev Bhattiprolu wrote: > Andi Kleen [ak@linux.intel.com] wrote: > | If you need something else in vfm to identify the CPU > | can't you just add it there? I wouldn't really call it vfm, it's > | really a "abstract cpu identifier per architecture". So if you > | need pvr just add it there. > > Ok. I will change vfm to cpuid_str and include pvr in it. Thanks. With that change it would be also cleaner to provide a get_cpuid_str() function by the architecture code, and then strcmp in the matching code, instead of having architecture specific compare code. -Andi -- ak@linux.intel.com -- Speaking for myself only