mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Andreas Ruprecht <andreas.ruprecht@fau.de>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	Uday Savagaonkar <savagaon@google.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Paul Bolle <pebolle@tiscali.nl>,
	Valentin Rothberg <valentinrothberg@gmail.com>,
	Stefan Hengelein <stefan.hengelein@fau.de>
Subject: Re: Unnecessary #ifdef in commit c863114122ac
Date: Thu, 21 May 2015 15:11:17 -0700	[thread overview]
Message-ID: <20150521221117.GA69587@jaegeuk-mac02.mot.com> (raw)
In-Reply-To: <555DBA77.6010503@fau.de>

Hi Andreas,

On Thu, May 21, 2015 at 12:59:03PM +0200, Andreas Ruprecht wrote:
> Hi Jaegeuk,
> 
> your commit c863114122ac ("f2fs crypto: add symlink encryption") showed
> up in linux-next today (i.e., next-20150521). I noticed it because we
> run a daily analysis on linux-next, checking for inconsistencies
> regarding #ifdef blocks [0,1].
> 
> In the commit, you create nested #ifdef blocks like the following:
> 
> #ifdef CONFIG_F2FS_FS_ENCRYPTION
> [...]
> #ifdef CONFIG_F2FS_FS_XATTR
> [...]
> #endif
> [...]
> #endif
> 
> The inner #ifdef, however, is unnecessary as CONFIG_F2FS_FS_XATTR is
> defined with a dependency on CONFIG_F2FS_FS_ENCRYPTION (line 78 in the
> corresponding Kconfig file at fs/f2fs/Kconfig).
> 
> This means, CONFIG_F2FS_FS_XATTR can never be disabled if
> CONFIG_F2FS_FS_ENCRYPTION is enabled, and that the inner #ifdef can
> safely be removed.
> 
> Do you want me to send a patch for this or do you want to do this yourself?

Agreed.
Let me please fix this in the original patch.

Thanks,

> 
> Best regards,
> 
> Andreas
> 
> [0] https://cados.cs.fau.de
> [1] http://www.linuxplumbersconf.org/2014/ocw/proposals/1863

      reply	other threads:[~2015-05-21 22:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 10:59 Andreas Ruprecht
2015-05-21 22:11 ` Jaegeuk Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150521221117.GA69587@jaegeuk-mac02.mot.com \
    --to=jaegeuk@kernel.org \
    --cc=andreas.ruprecht@fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=savagaon@google.com \
    --cc=stefan.hengelein@fau.de \
    --cc=tytso@mit.edu \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®