From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757423AbbEVS4m (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 May 2015 14:56:42 -0400
Received: from shards.monkeyblade.net ([149.20.54.216]:49712 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757119AbbEVS4j convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 May 2015 14:56:39 -0400
Date: Fri, 22 May 2015 14:56:36 -0400 (EDT)
Message-Id: <20150522.145636.734827115116283588.davem@davemloft.net>
To: linus.luessing@c0d3.blue
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, stephen@networkplumber.org,
        herbert@gondor.apana.org.au, roopa@cumulusnetworks.com,
        cwang@twopensource.com, sashok@cumulusnetworks.com,
        wkok@cumulusnetworks.com
Subject: Re: [PATCHv2 net-next] bridge: allow setting hash_max +
 multicast_router if interface is down
From: David Miller <davem@davemloft.net>
In-Reply-To: <1432301557-6928-1-git-send-email-linus.luessing@c0d3.blue>
References: <1432301557-6928-1-git-send-email-linus.luessing@c0d3.blue>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 May 2015 11:56:39 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Linus Lüssing <linus.luessing@c0d3.blue>
Date: Fri, 22 May 2015 15:32:37 +0200

> @@ -1786,14 +1784,8 @@ int br_multicast_set_router(struct net_bridge *br, unsigned long val)
>  	case 1:
>  		br->multicast_router = val;
>  		err = 0;
> -		break;
> -
> -	default:
> -		err = -EINVAL;
> -		break;
>  	}

Please don't remove the break; statement.

> @@ -1827,14 +1817,8 @@ int br_multicast_set_port_router(struct net_bridge_port *p, unsigned long val)
>  			break;
>  
>  		br_multicast_add_router(br, p);
> -		break;
> -
> -	default:
> -		err = -EINVAL;
> -		break;
>  	}
>  
> -unlock:
>  	spin_unlock(&br->multicast_lock);
>  
>  	return err;

Likewise.

Thanks.