From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757022AbbEVToG (ORCPT ); Fri, 22 May 2015 15:44:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47078 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756229AbbEVToE (ORCPT ); Fri, 22 May 2015 15:44:04 -0400 Date: Fri, 22 May 2015 12:44:03 -0700 From: Andrew Morton To: Randy Dunlap Cc: Vishnu Pratap Singh , linux-kernel@vger.kernel.org, cpgs@samsung.com Subject: Re: [PATCH] init/do_mounts: Add create_dev() failure log Message-Id: <20150522124403.bb11b61c21f6ca19e7435c85@linux-foundation.org> In-Reply-To: <555F5DD8.8070700@infradead.org> References: <1432298274-7708-1-git-send-email-vishnu.ps@samsung.com> <555F5DD8.8070700@infradead.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 May 2015 09:48:24 -0700 Randy Dunlap wrote: > On 05/22/15 05:37, Vishnu Pratap Singh wrote: > > if create_dev() function fails to create the root mount device (/dev/root), > > then it goes to panic as root device not found but there is no check/log > > present in case of failure, So i have added the log in case it fails to create > > the root device. It will help in debugging. > > > > Signed-off-by: Vishnu Pratap Singh > > --- > > init/do_mounts.h | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/init/do_mounts.h b/init/do_mounts.h > > index f5b978a..40c85e9 100644 > > --- a/init/do_mounts.h > > +++ b/init/do_mounts.h > > @@ -15,8 +15,12 @@ extern int root_mountflags; > > > > static inline int create_dev(char *name, dev_t dev) > > { > > + int ret; > > sys_unlink(name); > > - return sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev)); > > + ret = sys_mknod(name, S_IFBLK|0600, new_encode_dev(dev)); > > + if(ret < 0) > > if (ret < 0) > > > + printk(KERN_ERR " Failed to create %s device !! err: %d\n", name, ret); > > Don't need space before 'Failed'. > > > + return ret; > > } Yup. And there's no reason for it to be inlined. Let's move it into do_mounts.c please.