From: Minfei Huang <mnfhuang@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Minfei Huang <mhuang@redhat.com>,
sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: Let compiler put module initialized function to section ".init.text"
Date: Fri, 22 May 2015 22:03:02 +0800 [thread overview]
Message-ID: <20150522140302.GA6104@huangminfeis-MacBook-Pro.local> (raw)
In-Reply-To: <20150522132528.GA20555@treble.redhat.com>
On 05/22/15 at 08:25P, Josh Poimboeuf wrote:
> On Fri, May 22, 2015 at 02:10:32PM +0800, Minfei Huang wrote:
> > From: Minfei Huang <mnfhuang@gmail.com>
> >
> > Usually we prefer to let compiler put the module initialized function to
> > section ".init.text". Thus this text in memory will be freed in future.
> >
> > Once we add the "__init" preceding function name, we can use following
> > command to find it in specfied section.
> >
> > $ objdump -t -j .init.text built-in.o
> >
> > built-in.o: file format elf64-x86-64
> >
> > SYMBOL TABLE:
> > 0000000000000000 l d .init.text 0000000000000000 .init.text
> > 0000000000000000 l F .init.text 000000000000004e klp_init
> >
> > Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
>
> The patch looks good but can you make the subject more concise? Maybe
> something like:
>
> livepatch: annotate klp_init() with __init
Sure. Will modify the subject.
Thanks
Minfei
>
> Thanks.
>
> --
> Josh
prev parent reply other threads:[~2015-05-22 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 6:10 Minfei Huang
2015-05-22 13:25 ` Josh Poimboeuf
2015-05-22 14:03 ` Minfei Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522140302.GA6104@huangminfeis-MacBook-Pro.local \
--to=mnfhuang@gmail.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mhuang@redhat.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®