mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: Roland McGrath <roland@hack.frob.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel:ptrace - Fix typo in comment in function __ptrace_unlink().
Date: Sun, 24 May 2015 20:47:46 +0200	[thread overview]
Message-ID: <20150524184746.GA18917@redhat.com> (raw)
In-Reply-To: <1432357715-4236-1-git-send-email-shailendra.capricorn@gmail.com>

So this "fix" is wrong.

But you know, even if it was correct... IMO, the fixes like this can
only make sense as a "while at it" part of the meaningful change.

On 05/23, Shailendra Verma wrote:
> 
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  kernel/ptrace.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/ptrace.c b/kernel/ptrace.c
> index c8e0e05..46249f9 100644
> --- a/kernel/ptrace.c
> +++ b/kernel/ptrace.c
> @@ -108,7 +108,7 @@ void __ptrace_unlink(struct task_struct *child)
>  
>  	/*
>  	 * If transition to TASK_STOPPED is pending or in TASK_TRACED, kick
> -	 * @child in the butt.  Note that @resume should be used iff @child
> +	 * @child in the butt.  Note that @resume should be used if @child
>  	 * is in TASK_TRACED; otherwise, we might unduly disrupt
>  	 * TASK_KILLABLE sleeps.
>  	 */
> -- 
> 1.7.9.5
> 


      parent reply	other threads:[~2015-05-24 18:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23  5:08 Shailendra Verma
2015-05-24  1:19 ` Valdis.Kletnieks
2015-05-24 18:47 ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150524184746.GA18917@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@hack.frob.com \
    --cc=shailendra.capricorn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome