From: Mark Brown <broonie@kernel.org>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Stéphane Marchesin" <stephane.marchesin@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Alexander Holler" <holler@ahsoftware.de>,
"Grant Likely" <grant.likely@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/21] regulator: core: Probe regulators on demand
Date: Mon, 25 May 2015 18:32:44 +0100 [thread overview]
Message-ID: <20150525173244.GE21577@sirena.org.uk> (raw)
In-Reply-To: <1432565608-26036-11-git-send-email-tomeu.vizoso@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Mon, May 25, 2015 at 04:53:14PM +0200, Tomeu Vizoso wrote:
> When looking up a regulator through its DT node, ensure that the
> corresponding device has been registered.
I'm sorry but I'm going to need a much better changelog to review this
patch. I can't entirely tell what the intended effect is supposed to
be, the subject line says we're probing things and the body says we're
registering things which aren't the same thing at all.
> if (node) {
> + of_platform_device_ensure(node);
This function doesn't appear in git so I'm guessing that some other
patch in the series adds it. See my reply to the first patch...
The obvious questions here based on the name are why we're doing
something specific to platform devices and why this isn't something
we're abstracting in the driver core (or at least generic firmware code)
- we're going to have the same thing with ACPI.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-25 17:33 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 14:53 [PATCH 00/21] On-demand device registration Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 01/21] regulator: core: Reduce critical area in _regulator_get Tomeu Vizoso
2015-05-25 17:18 ` Mark Brown
2015-05-25 17:45 ` Mark Brown
2015-05-25 14:53 ` [PATCH 02/21] ARM: tegra: Add gpio-ranges property Tomeu Vizoso
2015-05-26 19:41 ` Stephen Warren
2015-05-27 14:18 ` Tomeu Vizoso
2015-05-27 14:49 ` Stephen Warren
2015-05-28 8:26 ` Tomeu Vizoso
2015-05-28 15:50 ` Stephen Warren
2015-06-16 7:53 ` Tomeu Vizoso
2015-06-02 11:28 ` Linus Walleij
2015-06-02 15:40 ` Stephen Warren
2015-06-16 8:42 ` Tomeu Vizoso
2015-06-16 20:32 ` Stephen Warren
2015-06-17 10:04 ` Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 03/21] ARM: tegra: Register drivers before devices Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 04/21] ARM: EXYNOS: " Tomeu Vizoso
2015-05-26 0:41 ` Krzysztof Kozlowski
2015-05-25 14:53 ` [PATCH 05/21] ARM i.MX6q: " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 06/21] of/platform: Add of_platform_device_ensure() Tomeu Vizoso
2015-05-26 18:56 ` Dmitry Torokhov
2015-05-27 8:04 ` Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 07/21] of/platform: Ensure device registration on lookup Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 08/21] gpio: Probe GPIO drivers on demand Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 09/21] gpio: Probe pinctrl devices " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 10/21] regulator: core: Probe regulators " Tomeu Vizoso
2015-05-25 17:32 ` Mark Brown [this message]
2015-05-26 6:17 ` Tomeu Vizoso
2015-05-26 9:36 ` Mark Brown
2015-05-26 15:08 ` Tomeu Vizoso
2015-05-26 16:54 ` Mark Brown
2015-05-26 17:53 ` Tomeu Vizoso
2015-05-26 19:55 ` Mark Brown
2015-05-25 14:53 ` [PATCH 11/21] drm: Probe panels " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 12/21] drm/tegra: Probe dpaux devices " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 13/21] i2c: core: Probe i2c master " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 14/21] pwm: Probe PWM chip " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 15/21] backlight: Probe backlight " Tomeu Vizoso
2015-05-26 7:18 ` Lee Jones
2015-05-26 7:25 ` Sascha Hauer
2015-05-26 8:39 ` Lee Jones
2015-05-26 12:01 ` Tomeu Vizoso
2015-05-26 13:34 ` Lee Jones
2015-05-25 14:53 ` [PATCH 16/21] usb: phy: Probe phy " Tomeu Vizoso
2015-05-26 14:44 ` Felipe Balbi
2015-05-25 14:53 ` [PATCH 17/21] clk: Probe clk providers " Tomeu Vizoso
2015-05-28 6:16 ` Michael Turquette
2015-05-25 14:53 ` [PATCH 18/21] pinctrl: Probe pinctrl devices " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 19/21] phy: core: Probe phy providers " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 20/21] dma: of: Probe DMA controllers " Tomeu Vizoso
2015-05-25 14:53 ` [PATCH 21/21] power-supply: Probe power supplies " Tomeu Vizoso
2015-05-28 4:33 ` [PATCH 00/21] On-demand device registration Rob Herring
2015-06-03 19:57 ` Grygorii.Strashko@linaro.org
2015-06-04 8:39 ` Tomeu Vizoso
2015-06-04 16:51 ` Grygorii.Strashko@linaro.org
2015-06-04 20:39 ` Alexander Holler
2015-06-08 12:26 ` Enrico Weigelt, metux IT consult
2015-06-08 18:14 ` Alexander Holler
2015-06-08 18:18 ` Alexander Holler
2015-06-22 15:23 ` Tomeu Vizoso
2015-06-23 0:01 ` Rob Herring
2015-06-02 8:48 ` Linus Walleij
2015-06-02 10:14 ` Tomeu Vizoso
2015-06-10 7:30 ` Linus Walleij
2015-06-10 10:19 ` Tomeu Vizoso
2015-06-10 12:23 ` Andrzej Hajda
2015-06-11 8:15 ` Linus Walleij
[not found] ` <5577F533.1060007@ahsoftware.de>
2015-06-11 8:12 ` Linus Walleij
2015-06-11 10:17 ` Alexander Holler
2015-06-11 11:24 ` Alexander Holler
2015-06-11 11:49 ` Alexander Holler
2015-06-11 12:30 ` Linus Walleij
2015-06-11 16:40 ` Alexander Holler
2015-06-12 7:25 ` Linus Walleij
2015-06-12 11:19 ` Alexander Holler
2015-06-12 11:36 ` Alexander Holler
2015-06-13 18:27 ` Alexander Holler
2015-06-15 8:58 ` Linus Walleij
2015-06-15 9:42 ` Alexander Holler
2015-06-11 13:09 ` Tomeu Vizoso
2015-06-03 21:12 ` Rob Clark
2015-06-04 21:03 ` Alexander Holler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525173244.GE21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=holler@ahsoftware.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stephane.marchesin@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®