From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbbEYTTw (ORCPT ); Mon, 25 May 2015 15:19:52 -0400 Received: from mail-bn1on0083.outbound.protection.outlook.com ([157.56.110.83]:50454 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751002AbbEYTTt (ORCPT ); Mon, 25 May 2015 15:19:49 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lists.infradead.org; dkim=none (message not signed) header.d=none; Date: Mon, 25 May 2015 12:04:09 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Michal Simek CC: Moritz Fischer , , , , , , , , , , , , , , , Subject: Re: [PATCH 2/3] dts: Adding docs for Xilinx LogiCORE IP mailbox driver. Message-ID: <20150525190409.GS18303@xsjsorenbubuntu> References: <1432251450-26352-1-git-send-email-moritz.fischer@ettus.com> <1432251450-26352-3-git-send-email-moritz.fischer@ettus.com> <555EC20C.6010703@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <555EC20C.6010703@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21568.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD044;1:YZF9ALWQYYK8/2muMnMrQs1+YtDca2crPnqMmR4itzVq8i7SAAd5hSShTVMacWEQYfh1teQh5jX2NBUGnMN3FzDQqduB7iLnpnvivwwph7nPmv9WenCh5q60xtpfAan9eld1D9ly3NWZhtaW/3Z0TCVzh7jZi2I2A9+db/21e7rUsqMIrFHXof54G3No1PCsSf/drSKG/XzSOu0dRSuZVhpyGsA22cpPnnr/UI4TdLksJDcBYUgmLDPX3LE9j61GpenplwDSmsQep9M4KzgAAvhXNTcpuJf8zriWPRWpc3pN9rJnHmX5iylRkpIJ4tz6 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(24454002)(479174004)(377424004)(51704005)(377454003)(189002)(199003)(4001350100001)(33656002)(83506001)(4001540100001)(110136002)(81156007)(36386004)(77156002)(62966003)(5001960100002)(33716001)(92566002)(87936001)(6806004)(46102003)(85182001)(23676002)(86362001)(77096005)(2950100001)(50466002)(54356999)(50986999)(76176999)(5001830100001)(64706001)(189998001)(19580395003)(76506005)(19580405001)(106466001)(63266004)(5001860100001)(47776003)(85202003)(57986006)(107986001)(4001450100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB014;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB014;2:W4QC5rVfutvuNoqVAe3EK3wxCDGzgBommuQk4JayerqyDSl7d0x9yV245sLYq77B;2:x3pF/aap34dmsWY5ZD6jUCgEyjiXSAA2T90Gwu8NmSvgccBcHtdCnZhgdKOXTXB9x8tNFIrBRtWp7vGcdm1XO15YNsw2guHEuAxrySneWRoE80xz0f5TKyBYdoLVkdW5fo2KaU5IlnFOpqSJkSg2SUJiv/9jf5WcXO+L2n6JZ2335Pyn/7CPfwmY2HHrkA695sGdVVc/No86+lucGjvESg04SXxg95esSSJLd/8H8Gg=;6:tfl2k0y4Ymq+gzYJTO/vQQyXvO1OMLf/Hn7BtAeMUZwut6jKsk4gNjCKMQiVp4pL1/PnK4Qe071OrR0sNUdM0AzI5cDbuLBsVYBlwqyBFnxIOWP/OEzt4JUnjrSg0Yy4SrWyqElx4duIDrXY5cDHk/fvJ0dMZ+MfnCa/7z+tbLFx6cDyOQaV7HsRdekjelIA9ZWez88hn3V2y57HqHQ+UhiuOplK08KpMHq82+gYAbXEaYN5qjj409Y0b5eXY7OIzGd7IzePvyvcblvjmzTD4s50lwqzTsf3YzokTE8y64fpqFFWcmoTxKondfq6Euh/OjKlWVJB7jmWoiB2Fn3MDxSKVIiXaxT0Xg9KzvQFmc6EaK7QqsPG1YmTQh3CSRzIXHItBCTsClaMvgCGreYRprpF2QSCCc4lpRVf06sfBIRgs1LNlqf+yfuxVEtarUT32nhAQ3Hq6y580NR4P8tmYuHSbkeB2QQ2sEAlliLSwRkuGo61G3snKlyXV6oTXCyD X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB014; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520002)(3002001);SRVR:BN1BFFO11HUB014;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB014; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB014;3:YljOUQNh/9v1Yyy3eFeqJ+/UfpUwOkv6OjyXcUVtf0AO6RaJMmf7xv7SYEOiJr65A2bMzPE+PemgshNGVoacuUh5dZgH/OW/bdAXzQzJ5XQci/4nlp854S+CT5WvR0NR05oD1B2dmj/AjPsgxpKdpz1YWSjcQst/fhvDryyG2oxsuL2XDywtkAT2B2BS5BHFwZsMs5iBqAoywuw6Z7UrZoPQJ5k8h8cudZY3h4evJJe5hxGzwdSlM9rABWfxrCAYdDOzzwratM79M0cp40faPhkoh76YfOHjE+OJo3mj6Cl7j8gDG2XSrt5OGyHjLgs4 X-Forefront-PRVS: 058707456E X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFCRkZPMTFIVUIwMTQ7OTppbFoyd2hMZmluMzNPNUtXby9LeDR0d2Ni?= =?utf-8?B?ZzFZenVodzlwYW1iaXk4SHNrUjA2S01LeC9xZUNxczdET3pkcmJWSkJLSzB3?= =?utf-8?B?MVZqNHA0U2k4cHphVG93UE5PN2FyK2doTXpLNGZES2VuNGI0QStQYjBDRVVw?= =?utf-8?B?U2p6Wnk4QVhxdlRvSDFINDZiOGN0NFdtc1JnQlBIMGkraEg5aHFhVlhxenFQ?= =?utf-8?B?ZW5aN0VZNTQzWFdnVnZjajBhR3IvMG1OWGExZGlTRDI0eGpaQW82ejE3M2dh?= =?utf-8?B?TEx3N0UxRnllSEZDNjNyak5OZ2ZGT0lNbjVpRDN2YURQRWZJZFRUcUxhNEZx?= =?utf-8?B?WUJDcGFmV3RySUtTbGFaQjBlWDIvUFlNMXR1cE90aGVBaEVtK1NhZnEwbFhi?= =?utf-8?B?NWt6clN1UEtRYUlEUkkzSlRIQnVRWDFpMzNqK0xpaE9ITG1HMHovT3FienVZ?= =?utf-8?B?Zm1tOXV2bjMwM21rc2ZaVFh1WndDM2tXUzNlUlFCT1c2R3U0MXNwbDhhR1cz?= =?utf-8?B?YWFtQXF0b0VmcHBONk5nZUM1dWJDRGUzVWlCdHFpUjdBRGs5cXJVYVF3OWll?= =?utf-8?B?TGQwTFl5a2R4VStxa0R0eTRMaC9yZmdqek5KeDNnMncvRVNjYXQrWVR5RGNs?= =?utf-8?B?QkYrbUJQUUhMVnpMYXVmZkViYktnSzlSR1E0anlmWEZRNHFBYndDeVNVNFFt?= =?utf-8?B?ZkIwd29CY3hvSU1qZCs5dDBaWDVpTmoyRXhUcEhUcVJmdHJ2MjhFZ0FDVDEv?= =?utf-8?B?UER1U0Y0Z3l0RUVIbkEyT1FMRlRYa2tyYnhTOG9jTVMxem1WUzNLV3NhdGEr?= =?utf-8?B?Mzc4aEhmeG14RXROMlcrME1CUE1aMlNBYmJTeTVCeHFFT0tObkkrNGJOTXNt?= =?utf-8?B?OE5vSUpQamxiM2FJdEhmcjkwbWtaUS9leEFuckhIL0NpV2JjSkZ1QzNhVE0x?= =?utf-8?B?dU5qQWtqd2dSWlMrNXM4WWUzU1UxL0EwZ1hYNFRRQzdBS25Geml3c0lYejJR?= =?utf-8?B?ZnFzQXJuMUx6RmsxblRaSVEyb0ZVeEVYWUpVRFpMTGZhL0haZmFLemVqeE54?= =?utf-8?B?SHZWZk80QWxtazRWR2VBQytrQUVLVCtTSXhraDI3a1hUSmNvcXRuWEVMMGpy?= =?utf-8?B?MVJIdVBSVnROK1FBYU9KWSswdVBJSi83WWZTUWRYTTVxdERSMDljWXpnQjRQ?= =?utf-8?B?Q09nRGw4NWFOczZ0K251Y2p4SjJqZnh4KzMwL2hkYnlLWFJyYmx5bTBlL0pJ?= =?utf-8?B?Sndxbm4rbGNBZ2tzQ0RzMXcrUUwxelg2aUtLaE9WUm9IV2xOd3E5eFZWTXJi?= =?utf-8?B?TWxSS2JtYlJBYy91anJidDNJYXRDbU9Mcld4UnhENUlYNTNlKzdGUUdMTG9H?= =?utf-8?B?SWZUVFA3VnFyeVJyNGpHWmdMZmoxTkpCakRrUE5uZnF2TWczQ0FSU3JadTBP?= =?utf-8?B?eGlvTTBLNWVpdG4xRDdabTBUWVNSSVhEY0g2RVN5bDBmZjNBTm5YU2hKZ01s?= =?utf-8?B?a3pwcWRRcE14ZWdwakxpT0NUaDdCaE9lZCtib0hMWGRXdE96a3NZRHhYMUtT?= =?utf-8?B?bzk0dUxESHRQSGhXZUU4SEtkTDUwUjVLWTJsVk5MWkpBWGt1RFRjb2VHS0ZP?= =?utf-8?B?ZXNhbmkvenkvaSttTDJVb051SzRxL2cwcEdjRUZHbW1laVVra2pzNWk1Zz09?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB014;3:IqguYw2qgcYWDN6GbOldxtqS3r4SxheF33uSfQy19zUDNNskTGlH0oRR6w7Q5jPlxKSMWxWWvKMh9qrSmKw1wi0OkZfreLz2yLT/2HA7zoJdGDNN7qFyhEl+F7mDPq7OtI0MH3m0oN3iOy2AwIW1JQ==;10:0D1e9sonVe9IClZlitjUGweDQn4CAzteteocTSqUUHbaO9/8ADfRTWjU9iDwabhL0OGCYGJyzRWUvlRKOFncJ05cFmKpnQJRhAketDS1Q9M= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2015 19:04:18.6300 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB014 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-05-22 at 07:43AM +0200, Michal Simek wrote: > On 05/22/2015 01:37 AM, Moritz Fischer wrote: > > Signed-off-by: Moritz Fischer > > --- > > .../bindings/mailbox/xilinx-mailbox.txt | 40 ++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > IRC the rule was to send binding first and then the driver. > > > diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > > new file mode 100644 > > index 0000000..e559743 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > > @@ -0,0 +1,40 @@ > > +Xilinx Mailbox Driver > > +===================== > > + > > +Required properties: > > +- compatible : "xlnx,mailbox-2.1". > > +- reg : physical base address of the mailbox and length of > > + memory mapped region. > > +- #mbox-cells: Common mailbox binding property to identify the number > > + of cells required for the mailbox specifier. Should be 1. > > + > > +Optional properties: > > +- interrupt-parent : interrupt source phandle. > > +- interrupts : interrupt number. The interrupt specifier format > > please be consistent with spacing around :. It doesn't look nice. > > > + depends on the interrupt controller parent. > > + > > +Example: > > + mbox: mailbox@0x40400000 { > > remove 0x prefix here. > > > + compatible = "xlnx,axi-mailbox-2.1"; > > + reg = <0x100 0x3c>; > > This is weird - it should start with 40400000. > Or is your physical address 0x100? > > > > + interrupt-parent = <&intc>; > > + interrupts = <5>; > > + #mbox-cells = <1>; > > + }; > > + > > +Mailbox client > > +=============== > > +"mboxes" and the optional "mbox-names" (please see > > +Documentation/devicetree/bindings/mailbox/mailbox.txt for details). Each value > > +of the mboxes property should contain a phandle to the mailbox controller > > +device node and second argument is the channel index. It must be 0 (hardware > > +support only one channel).The equivalent "mbox-names" property value can be > > .The > > > +used to give a name to the communication channel to be used by the client user. > > + > > +Example: > > + mclient0: mclient0@0x400 { > > ditto. > > > + compatible = "client-1.0"; > > + reg = <0x400 0x10>; > > + mbox-names = "mbox", "mbox-rx"; This seems to consume two mailboxes but... > > + mboxes = <&mbox 0>; ... this seems to describe only one, or am I mistaken? Sören