From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754569AbbEZRhg (ORCPT ); Tue, 26 May 2015 13:37:36 -0400 Received: from one.firstfloor.org ([193.170.194.197]:52363 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbbEZRhc (ORCPT ); Tue, 26 May 2015 13:37:32 -0400 Date: Tue, 26 May 2015 19:37:30 +0200 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, eranian@google.com, Andi Kleen Subject: Re: [PATCH 04/10] perf, tools, report: Add processing for cycle histograms Message-ID: <20150526173730.GP19417@two.firstfloor.org> References: <1431265926-4766-1-git-send-email-andi@firstfloor.org> <1431265926-4766-5-git-send-email-andi@firstfloor.org> <20150526100912.GE6555@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150526100912.GE6555@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > hum, so this is assuming that having cycles fort 1st entry > means there'll be for the rest? > Also in that case why is there the '!= cycles' check within > addr_map_symbol__account_cycles ? > It means there might be. It's just a short cut. But rarely branches may still have 0 cycles, so it still needs to be checked later. In theory it could miss a valid one if the first happened to be zero, but that seems very unlikely. -Andi -- ak@linux.intel.com -- Speaking for myself only.