From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751623AbbEZShu (ORCPT ); Tue, 26 May 2015 14:37:50 -0400 Received: from mail-by2on0061.outbound.protection.outlook.com ([207.46.100.61]:35619 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751051AbbEZShs (ORCPT ); Tue, 26 May 2015 14:37:48 -0400 X-Greylist: delayed 84808 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 May 2015 14:37:48 EDT Authentication-Results: spf=pass (sender IP is 62.221.5.235) smtp.mailfrom=xilinx.com; arndb.de; dkim=none (message not signed) header.d=none; Date: Tue, 26 May 2015 11:37:34 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Arnd Bergmann CC: , Masahiro Yamada , , Linus Walleij , Michal Simek , Subject: Re: [PATCH] pinctrl: zynq: change error code for pinctrl_register failure Message-ID: <20150526183734.GA31081@xsjsorenbubuntu> References: <1432613909-13457-1-git-send-email-yamada.masahiro@socionext.com> <4437293.G26yCXqFQH@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4437293.G26yCXqFQH@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21570.003 X-TM-AS-User-Approved-Sender: Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD013;1:fnM0fBP6QjUiR+PaS8/cdyvCeB76Ccmv4Q/qNL8WdnB0gB0oJ8x6KCBqGR9WA+7yGpe7+vVHt1AGeEDhuWxiUHCu5wb0MTC7il3hWb+OwaMgKxJpeWQBzoD5IcxgQADwvRI2yo/oEhfKb9182MXaAfbCS13K9IP/GGRHmj9N0iCqjHFvOIxdGIV57JcAT8Lri4M7g0w1/2+M1c+uPCU+3Ex1z4V7DSZ+jPWJAOX3ONetzRRPRGisjZ1fXHh4V45+oQnDya+rO2iTKI4KCepDqg== X-Forefront-Antispam-Report: CIP:62.221.5.235;CTRY:GB;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(51704005)(189002)(199003)(24454002)(377424004)(23676002)(16796002)(54356999)(76176999)(50986999)(86362001)(77096005)(83506001)(33656002)(57986006)(63266004)(33716001)(76506005)(46102003)(2950100001)(85182001)(47776003)(64706001)(106466001)(4001350100001)(81156007)(92566002)(189998001)(5001960100002)(110136002)(36386004)(4001540100001)(85202003)(6806004)(87936001)(62966003)(5001860100001)(50466002)(5001830100001)(77156002)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB037;H:xir-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-62-221-5-235.ipspace.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB037;2:AO5RWLDOvDeZx6jdZsfbbYP/5XU2AdCGSe68grhxEBPdeCXF7eg+e53ISjjgt9EG;2:Js83t1DsPOZiyCSe+8C7ozkeBbSvEdUjuqnNH/JpzxMqftnr4bBH8v8B3i+wUXN64l/x/i7BXeNL3dRjZfvyxKecpCZLTQYrCrl6Y2XK9Z65p+6KPBWo3wryZ9nq+UELGHMjkgSK97pia3YDGf2MwyD/qyUHdgTAghUeI6YaHL1TjeMsW518C2lEytRikHle1WlqjctZfTWbiAuh5pQQmyuM+D026bmDbviarrOHsVo=;6:bM608AwEmXefj0irFn39nozBu1wqoCSVri5A7UMgwUtz2ZXZOdyJxbRIM5BLxENhH2f09j+/1PB330JeQenkpsHqREHupgs0UN6co4UUnpQMv7Y1Ra6TgDC2cjhezUFodPiSSly73X4FPdDJ4+U06vA7lOLKCV+EqQ2J9cJljKel79qItOuNnyQYIrIDpdnQQwVzLznxVYEAKUuzhE26cyOh8LTQPHVJ1exg+Ym//tp3I2I7W2N8GOXbQgHpEe8eMSE0BkFyKfanwgGujJxJ4fJq3V+gbmo44pPXN7tvfQGWRkY2vPjsVSSGarMW1DxEYVlOLsBTIEkZ9KRkherLeGvOYCTZ+LC8ZlF9OO8Y2iEovIRShGzJO5w9NTSlPPuvJp/qtAz4lJNglVpaRyKJ0ediuFrQpYgc7xQ0uGjtPIwwshuNsejR39o/KDoOIpnjHwbjxlWN9HqtZS8pUfi1JY1Fl3BcFaWhPFS3/0clE3DQVF9punqJtuK7wxJnqBiM X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB037; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520002)(5005006)(3002001);SRVR:BL2FFO11HUB037;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB037; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB037;3:01Zudwm7S0ZBo4KlIvUXy2bzYMqfHsx/16CEbty1dkReUAfS8/guIbia5sPCxw/WfQHcLCh6A5UelTU3d6SEWeA0aCCnMvLotYXx7ItMkxIEXg+1ExgOwuscbE/4MXKiDpzNDSF1vxlFKk1MSZRoL3A/Vaxx1rG/ZWqSy5IukOwmXKUNbFogKWSzFwAWcqubennUcfvqjrsb917jWp5ef69Xw/NCKoxdz3KR3KNPlFP2JtsmfHaCJhNa+ZkvXzrUfPSiQGyqkYrKujZV0M+k2jHESShz2SBq4Z/1MP6GNppMkOHO70Ud1inpSdMoKTrJ X-Forefront-PRVS: 0588B2BD96 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJGRk8xMUhVQjAzNzs5OmdocFFSM0llTzlkNW1sZjE3N1A5K2dHZExs?= =?utf-8?B?NkxTa3AwUjJ2QkFEZHFtZE5QNG5HWEhOeWIzOEcxS1dGS3Z1WFZrT1l4VTNG?= =?utf-8?B?QlhBOVpsTXdhUFR3VUtSYm5JWHpwV1duMERmWFl0dVZOTzdoSmVBaEY0c2dG?= =?utf-8?B?V29jVlJ5MlZpbXkweEJ6a2Q3TDBOWGdCQW9zRUtMSGdsRm9pWkdVaXpwSkFQ?= =?utf-8?B?VmhkL1NPYU1naUpzeDh4V2tiWHViY1FoOW5kY0RyRnQ3UVl6NGtCdW1wQXQ1?= =?utf-8?B?U2s3OW43ODJ5RCs1YUppd2RNM25JWmRHQ2w4MVhWZzNXbUdOUHBCZy9IeWVG?= =?utf-8?B?NzA4UUFXU2ErZlR3SUJ6OEw1M0xyNmorRTM5b3FGZ1JhSnpMbGtSZWxmcW45?= =?utf-8?B?QXhsUlJlVVZOY3pHY2ZuSUNCVE05OWplUnNIeHU1Q1I3ZDZyKzN4YkJ4OGdU?= =?utf-8?B?K0F6MDREbmIxT2dSTWpaZkFNV2RHMU1paWdLSW9WSVpRZC9DeDBib2tQYWxG?= =?utf-8?B?RkJFREtJemI3dVdSYi9PeFJNbFVLS0ZnZzNCOHNUSllDTnNYL09hSGxCV1R6?= =?utf-8?B?NnBBWGRzamY3a0QycWJzaUxDQ2hub05zNHZxcHcvNWJqTkg4MDBzK1ZSdTVG?= =?utf-8?B?bTFkQTZpdG9IbmNXNkpXUStJRStsRzgyQUdvRU13dWZ4VWY3MUIyclh4NnIy?= =?utf-8?B?SGlFcjNERlNESDN1UER6U0ZOSWY3cExSclZPTkx6Q2ZPcUhya0lKa0c5ekR5?= =?utf-8?B?Z2dqSW9HSEI0ckZ4T1RXODFYUWxhUFdnVmoxbkxIZnYvMHRDalZNc2t3QUhW?= =?utf-8?B?K05CTDFJd1hmT3ZQNnJBWi9QSkpqZUJvVXc2Y2M3T3E4b3BjdnowMzNWbzkv?= =?utf-8?B?ZTJBeUtZcFR1dzZpdTluZVdhZUR4QjhaVkZiczlmUk1sYlBobTRxR1F5QTNQ?= =?utf-8?B?UEN2c252T0gzWkt5QmRwc2hzQ09qU2Qwd3VjdGFhMWpvSWkzM0NPNEo5WjlX?= =?utf-8?B?eE9zMjlzUkdlMjRUdDVBOTZqR3E0REVKK1hBT3lwMnE2cFk1ejFiVm0yVDl4?= =?utf-8?B?TitScWFUN0JFT2piMko1cmVNQkdNMHphWkZ6VXB6bXBRTHd0LzVOVC9YTFJK?= =?utf-8?B?MXhSdEFMVUFFS3czZjdxWSsxZVpFY2FtK2hCNjg3ZmJsSUFYRTRkanFKM2pN?= =?utf-8?B?K0ExK2ZGTzVxRllGYlpFL01GQVFKSTNHMnFhd012N09LRGlTenRlTWRoa0hU?= =?utf-8?B?bVpKMzdwMG1MVWplcUpiZ3E5VWpaWFBROUhQa3pvUFNmb21YOC9XeWlBWklI?= =?utf-8?B?cmZGcUlTbkN3RUdSSlI1Qlc3TmRTWTA4S0lPOEFmQmt0UXpRZE1tMjRQSStX?= =?utf-8?B?N1pscW9jZCtBOGJGeHRBM3lUVGNVc1g4eXhueW1RT25YdjRkcVBmUmwxM3NM?= =?utf-8?B?NDlaQ2VWUk50Y241RXpEaEhLOEtDMkM3ckZXcUlnTTZzYTAzdzB3NEVXdEZS?= =?utf-8?Q?Zx3eNVmH7tP5BzxDtmUiSetGs=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB037;3:J+YtunWwz9Trv9YP5EoRB2+vI99vQwL5qUS4NuIeihc0ag46AJWE4BMbppPyeuqSK5TJjxeG/5BS8093NXXDiHCUlaZeyNDvTAQEhE4rf2bpauFLp+O7a0AAW33DvGl4wzEAMetH9/mDRfk3H2+cww==;10:JafBEMqrBEOHLATCMpmUd8bVuwXeYulzTuy8vtVe0+xyJa4ViPj+j/SNafnYuM56PUrgVxXBU31OIPCYDIaJIehNmHZ4VtqpCOAsIU3hgtA= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2015 18:37:46.2606 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[62.221.5.235];Helo=[xir-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB037 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-05-26 at 10:12AM +0200, Arnd Bergmann wrote: > On Tuesday 26 May 2015 13:18:29 Masahiro Yamada wrote: > > diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c > > index 04748a4..0ff653c 100644 > > --- a/drivers/pinctrl/pinctrl-zynq.c > > +++ b/drivers/pinctrl/pinctrl-zynq.c > > @@ -1141,7 +1141,7 @@ static int zynq_pinctrl_probe(struct platform_device *pdev) > > > > pctrl->pctrl = pinctrl_register(&zynq_desc, &pdev->dev, pctrl); > > if (!pctrl->pctrl) > > - return -ENOMEM; > > + return -EINVAL; > > > > platform_set_drvdata(pdev, pctrl); > > > > > > One choice seems as bad as the other to me ;-) > > Could we add a pinctrl_register_reason() variant that returns a meaningful > error code as ERR_PTR? I agree with Arnd. As long as we don't get a precise error code we can just keep the current one. Sören