From: Tejun Heo <tj@kernel.org>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_mvebu: Fix wrongly set base address for the MBus window setting
Date: Tue, 26 May 2015 14:47:28 -0400 [thread overview]
Message-ID: <20150526184728.GJ7099@htj.duckdns.org> (raw)
In-Reply-To: <1432658843-27622-1-git-send-email-gregory.clement@free-electrons.com>
On Tue, May 26, 2015 at 06:47:23PM +0200, Gregory CLEMENT wrote:
> From: Nadav Haklai <nadavh@marvell.com>
>
> According to the Armada 38x datasheet, the window base address
> registers value is set in bits [31:4] of the register and corresponds
> to the transaction address bits [47:20].
>
> Therefore, the 32bit base address value should be shifted right by
> 20bits and left by 4bits, resulting in 16 bit shift right.
>
> The bug as not been noticed yet because if the memory available on
> the platform is less than 2GB, then the base address is zero.
>
> [gregory.clement@free-electrons.com: add extra-explanation]
>
> Fixes: a3464ed2f14 (ata: ahci_mvebu: new driver for Marvell Armada 380
> AHCI interfaces)
> Signed-off-by: Nadav Haklai <nadavh@marvell.com>
> Reviewed-by: Omri Itach <omrii@marvell.com>
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Cc: <stable@vger.kernel.org>
Applied to libata/for-4.1-fixes.
Thank you.
--
tejun
prev parent reply other threads:[~2015-05-26 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 16:47 Gregory CLEMENT
2015-05-26 18:47 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526184728.GJ7099@htj.duckdns.org \
--to=tj@kernel.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=hdegoede@redhat.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®