From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752622AbbE0ERG (ORCPT ); Wed, 27 May 2015 00:17:06 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:56469 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbbE0ERB (ORCPT ); Wed, 27 May 2015 00:17:01 -0400 Date: Tue, 26 May 2015 21:16:58 -0700 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Matthew Garrett , Dmitry Torokhov , Valdis Kletnieks , lkml , platform-driver-x86@vger.kernel.org, Greg Kroah-Hartman Subject: Re: dell_rbtn - kernel panic at boot... Message-ID: <20150527041658.GB14480@fury.dvhart.com> References: <5875.1432260403@turing-police.cc.vt.edu> <20150525044432.GA38428@fury.dvhart.com> <20150525050121.GA28810@srcf.ucam.org> <201505250803.42410@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201505250803.42410@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2015 at 08:03:42AM +0200, Pali Rohár wrote: > On Monday 25 May 2015 07:01:21 Matthew Garrett wrote: > > On Sun, May 24, 2015 at 09:44:32PM -0700, Darren Hart wrote: > > > Greg, Matthew, I'm tempted to recommend this 434 line driver be > > > rolled into dell-laptop.c. Any strong opinions? > > > > Mrm. It's slightly conceptually nasty in that one's an ACPI driver > > and one's calling a Dell custom interface, but I think merging them > > is probably the last bad answer. > > I think merging does not fix our problem. dell laptop rfkill driver > needs to be initialized after dell-rbtn acpi driver register itself. If they were the same driver, you could control this ordering. > > And dell-laptop and dell-rbtn are two different devices (one dell smbios > and one acpi) and it for me it sounds like bad idea too... We all agree it's a bad idea - the point Mathew and I made was it may be the "least bad" idea (all the others may be worse). I'm looking into this, but I don't have an easy answer for you. This one is going to take some research on your part to get to the right answer. -- Darren Hart Intel Open Source Technology Center