From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752050AbbE0JkJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 05:40:09 -0400
Received: from zimbra13.linbit.com ([212.69.166.240]:60233 "EHLO
	zimbra13.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750755AbbE0JkG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 05:40:06 -0400
X-Greylist: delayed 503 seconds by postgrey-1.27 at vger.kernel.org; Wed, 27 May 2015 05:40:06 EDT
Date: Wed, 27 May 2015 11:31:36 +0200
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [Drbd-dev] [PATCH] block:drbd:drbd_receiver - Change 1/0 to
 true/false for bool type variable rv in function overlapping_resync_write().
Message-ID: <20150527093136.GJ18767@soda.linbit>
Mail-Followup-To: Shailendra Verma <shailendra.capricorn@gmail.com>,
	drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
References: <1432584909-5349-1-git-send-email-shailendra.capricorn@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432584909-5349-1-git-send-email-shailendra.capricorn@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 26, 2015 at 01:45:09AM +0530, Shailendra Verma wrote:
> In function overlapping_resync_write() variable rv is bool type.
> Hence assigning the values as true/false instead of 1/0.

I like 0 and 1 better.  So unless the powers that be rule this to be the
recommended or mandatory coding style, I consider this just noise.

    Lars

> -	bool rv = 0;
> +	bool rv = false;

> -			rv = 1;
> +			rv = true;