From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbbE0QaZ (ORCPT ); Wed, 27 May 2015 12:30:25 -0400 Received: from smtprelay0083.hostedemail.com ([216.40.44.83]:56359 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751358AbbE0QaW (ORCPT ); Wed, 27 May 2015 12:30:22 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2904:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:5007:6261:6742:7875:9010:10004:10400:10848:10967:11026:11232:11658:11914:12043:12109:12296:12438:12517:12519:12740:13069:13311:13357:13972:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: hope94_1fe9152bc6006 X-Filterd-Recvd-Size: 3059 Date: Wed, 27 May 2015 12:30:18 -0400 From: Steven Rostedt To: "Ankit Gupta" Cc: gavidov@codeaurora.org, sdharia@codeaurora.org, ivan.ivanov@linaro.org, svarbanov@mm-sol.com, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, sboyd@codeaurora.org, collinsd@codeaurora.org, osvaldob@codeaurora.org, linux-kernel@vger.kernel.org, mlocke@codeaurora.org, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH v2] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver Message-ID: <20150527123018.2d61d3fb@gandalf.local.home> In-Reply-To: <1e85ad053b3b52c4d749580cce52b737.squirrel@www.codeaurora.org> References: <1432743042-22817-1-git-send-email-ankgupta@codeaurora.org> <1e85ad053b3b52c4d749580cce52b737.squirrel@www.codeaurora.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 May 2015 10:21:10 -0600 "Ankit Gupta" wrote: > > The spmi-pmic-arb is also an interrupt controller. It gets a > > single aggregate irq and disseminates it to individual > > pmic-peripheral drivers. Each pmic-peripheral has a unique apid > > number, and can have multiple interrupt capable functions. > > The registered apid range shows the lowest and highest apid > > numbers of pmic-peripheral drivers which request irqs. Pid is > > the base address of that peripheral. For performance measurement, > > tracepoints are added at the beginning of the aggregate irq and > > at the end of the individual pmic-peripheral irqs. > > > > Following is a list showing the new tracepoint events: > > > > spmi_pmic_arb_aggregate_irq_start: aggregate irq number and registered > > apid range. > > > > spmi_pmic_arb_apid_irq_end: apid, irq, func_num, sid and pid. > > > > SPMI Interrupts tracepoints can be enabled like: > > > > echo 1 >/sys/kernel/debug/tracing/events/spmi-pmic-arb/enable > > > > and will dump messages that can be viewed in > > /sys/kernel/debug/tracing/trace that look like: > > ... spmi_pmic_arb_aggregate_irq_start: irq=150 registered apid > > range=(3,189) > > ... spmi_pmic_arb_apid_irq_end: apid=3 irq=1 func_num=0 sid=0 pid=0x8 > > > > Suggested-by: Sagar Dharia > > Signed-off-by: Gilad Avidov > > Signed-off-by: Ankit Gupta > > --- > > --- > Changes since V1: > - pass ppid from driver to evaluate pid and sid in trace file itself. > - type of apid range change from int to u16 as max range can be 512. > - type of func_num change from int to u8, as max it can be 8. > --- > Tracing part looks fine to me. Acked-by: Steven Rostedt -- Steve