From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752121AbbE0OBE (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 10:01:04 -0400
Received: from mail-pd0-f170.google.com ([209.85.192.170]:35385 "EHLO
	mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751445AbbE0OA6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 10:00:58 -0400
Date: Wed, 27 May 2015 22:59:28 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: mingo@redhat.com, ak@linux.intel.com,
        Michael Ellerman <mpe@ellerman.id.au>, Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Paul Mackerras <paulus@samba.org>, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] perf: Add power8 PMU events in JSON format
Message-ID: <20150527135928.GB29557@danjae.kornet>
References: <1432080130-6678-1-git-send-email-sukadev@linux.vnet.ibm.com>
 <1432080130-6678-5-git-send-email-sukadev@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1432080130-6678-5-git-send-email-sukadev@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 19, 2015 at 05:02:10PM -0700, Sukadev Bhattiprolu wrote:
> The power8.json and 004d0100.json files describe the PMU events in the
> Power8 processor.
> 
> The jevents program from the prior patches will use these JSON files
> to create tables which will then be used in perf to build aliases for
> PMU events. This in turn would allow users to specify these PMU events
> by name:
> 
> 	$ perf stat -e pm_1plus_ppc_cmpl sleep 1
> 
> Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---

[SNIP]
> +  {
> +    "EventCode": "0x2505e",
> +    "EventName": "PM_BACK_BR_CMPL",
> +    "BriefDescription": "Branch instruction completed with a target address less than current instruction address,",
> +    "PublicDescription": "Branch instruction completed with a target address less than current instruction address.,"

Can't we remove PublicDescription field if it's identical to
BriefDescription?  It seems just wasting spaces..

Thanks,
Namhyung


> +  },
> +  {
> +    "EventCode": "0x4082",
> +    "EventName": "PM_BANK_CONFLICT",
> +    "BriefDescription": "Read blocked due to interleave conflict. The ifar logic will detect an interleave conflict and kill the data that was read that cycle.,",
> +    "PublicDescription": "Read blocked due to interleave conflict. The ifar logic will detect an interleave conflict and kill the data that was read that cycle.,"
> +  },
> +  {
> +    "EventCode": "0x10068",
> +    "EventName": "PM_BRU_FIN",
> +    "BriefDescription": "Branch Instruction Finished,",
> +    "PublicDescription": "Branch Instruction Finished .,"
> +  },
> +  {
> +    "EventCode": "0x20036",
> +    "EventName": "PM_BR_2PATH",
> +    "BriefDescription": "two path branch,",
> +    "PublicDescription": "two path branch.,"
> +  },
> +  {
> +    "EventCode": "0x5086",
> +    "EventName": "PM_BR_BC_8",
> +    "BriefDescription": "Pairable BC+8 branch that has not been converted to a Resolve Finished in the BRU pipeline,",
> +    "PublicDescription": "Pairable BC+8 branch that has not been converted to a Resolve Finished in the BRU pipeline,"
> +  },
> +  {
> +    "EventCode": "0x5084",
> +    "EventName": "PM_BR_BC_8_CONV",
> +    "BriefDescription": "Pairable BC+8 branch that was converted to a Resolve Finished in the BRU pipeline.,",
> +    "PublicDescription": "Pairable BC+8 branch that was converted to a Resolve Finished in the BRU pipeline.,"
> +  },