From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753187AbbE0RsY (ORCPT ); Wed, 27 May 2015 13:48:24 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:33458 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751612AbbE0RsW (ORCPT ); Wed, 27 May 2015 13:48:22 -0400 Date: Wed, 27 May 2015 13:48:17 -0400 From: Tejun Heo To: Johannes Weiner Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, jack@suse.cz, hch@infradead.org, linux-fsdevel@vger.kernel.org, vgoyal@redhat.com, lizefan@huawei.com, cgroups@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.cz, clm@fb.com, fengguang.wu@intel.com, david@fromorbit.com, gthelen@google.com, khlebnikov@yandex-team.ru Subject: Re: [PATCH v2 11/51] memcg: implement mem_cgroup_css_from_page() Message-ID: <20150527174817.GP7099@htj.duckdns.org> References: <1432329245-5844-1-git-send-email-tj@kernel.org> <1432329245-5844-12-git-send-email-tj@kernel.org> <20150527161344.GO7099@htj.duckdns.org> <20150527170955.GA25324@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150527170955.GA25324@cmpxchg.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, May 27, 2015 at 01:09:55PM -0400, Johannes Weiner wrote: > Regular page migration uses mem_cgroup_migrate() as well, but it's not > a problem as it ensures that the old page doesn't have any outstanding > references at that point. Ooh, I see. > It's only replace_page_cache_page() that calls mem_cgroup_migrate() on > a live page breaking mem_cgroup_css_from_page(). > > So the page looks fine, I'd just update the culprit function in the > changelog and kerneldoc. Alright, will update the comment and description. Thanks. -- tejun