From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754170AbbE0TP2 (ORCPT ); Wed, 27 May 2015 15:15:28 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34106 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753809AbbE0TPZ (ORCPT ); Wed, 27 May 2015 15:15:25 -0400 Date: Wed, 27 May 2015 12:15:21 -0700 From: Brian Norris To: Richard Weinberger Cc: Wenlin Kang , "linux-mtd@lists.infradead.org" , David Woodhouse , LKML Subject: Re: [PATCH] mtd: blktrans: use better error code for unimplemented ioctl() Message-ID: <20150527191429.GF27753@ld-irv-0074> References: <1431498556-21275-1-git-send-email-wenlin.kang@windriver.com> <20150520193325.GK11598@ld-irv-0074> <20150521080511.GF11112@norris-Latitude-E6410> <555DB0AB.2000801@nod.at> <20150521175431.GC11598@ld-irv-0074> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150521175431.GC11598@ld-irv-0074> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2015 at 10:54:31AM -0700, Brian Norris wrote: > In commit 50183936254b ("mtd: blktrans: change blktrans_getgeo return > value") we fixed the problem that ioctl(HDIO_GETGEO) might return 0 > (success) for mtdblock devices which did not implement the feature and > would leave a blank (zero) result. > > But now, let's get the error code right. Other code paths on this ioctl > tend to use -ENOTTY to notify the user that the ioctl() is not supported > for the device, so let's use that instead of -EOPNOTSUPP. > > Suggested-by: Richard Weinberger > Signed-off-by: Brian Norris > --- > Against l2-mtd.git (linux-next) Applied.