From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [for-next][PATCH 3/4] ring-buffer: Allways do the trace_recursive checks
Date: Wed, 27 May 2015 20:49:20 -0400 [thread overview]
Message-ID: <20150528004950.413671921@goodmis.org> (raw)
In-Reply-To: <20150528004917.607818791@goodmis.org>
[-- Attachment #1: 0003-ring-buffer-Allways-do-the-trace_recursive-checks.patch --]
[-- Type: text/plain, Size: 1298 bytes --]
From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>
Currently the trace_recursive checks are only done if CONFIG_TRACING
is enabled. That was because there use to be a dependency with tracing
for the recursive checks (it used the task_struct trace recursive
variable). But now it uses its own variable and there is no dependency.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/ring_buffer.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 8b0421eca001..1c037ad923db 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -2637,8 +2637,6 @@ rb_reserve_next_event(struct ring_buffer *buffer,
return NULL;
}
-#ifdef CONFIG_TRACING
-
/*
* The lock and unlock are done within a preempt disable section.
* The current_context per_cpu variable can only be modified
@@ -2708,13 +2706,6 @@ trace_recursive_unlock(struct ring_buffer_per_cpu *cpu_buffer)
cpu_buffer->current_context &= cpu_buffer->current_context - 1;
}
-#else
-
-#define trace_recursive_lock(cpu_buffer) (0)
-#define trace_recursive_unlock(cpu_buffer) do { } while (0)
-
-#endif
-
/**
* ring_buffer_lock_reserve - reserve a part of the buffer
* @buffer: the ring buffer to reserve from
--
2.1.4
next prev parent reply other threads:[~2015-05-28 0:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 0:49 [for-next][PATCH 0/4] ring-buffer: Some minor updates Steven Rostedt
2015-05-28 0:49 ` [for-next][PATCH 1/4] ring-buffer: Add unlikelys to make fast path the default Steven Rostedt
2015-05-28 0:49 ` [for-next][PATCH 2/4] ring-buffer: Move recursive check to per_cpu descriptor Steven Rostedt
2015-05-28 0:49 ` Steven Rostedt [this message]
2015-05-28 1:16 ` [for-next][PATCH 3/4] ring-buffer: Allways do the trace_recursive checks Steven Rostedt
2015-05-28 0:49 ` [for-next][PATCH 4/4] ring-buffer: Add trace_recursive checks to ring_buffer_write() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528004950.413671921@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome