From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753768AbbE1Lqi (ORCPT ); Thu, 28 May 2015 07:46:38 -0400 Received: from foss.arm.com ([217.140.101.70]:54512 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753475AbbE1LqU (ORCPT ); Thu, 28 May 2015 07:46:20 -0400 Date: Thu, 28 May 2015 12:48:04 +0100 From: Morten Rasmussen To: Mike Galbraith Cc: Josef Bacik , "riel@redhat.com" , "mingo@redhat.com" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH RESEND] sched: prefer an idle cpu vs an idle sibling for BALANCE_WAKE Message-ID: <20150528114804.GA17879@e105550-lin.cambridge.arm.com> References: <1432761736-22093-1-git-send-email-jbacik@fb.com> <1432784798.3237.81.camel@gmail.com> <20150528094914.GJ26396@e105550-lin.cambridge.arm.com> <1432810664.3237.135.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432810664.3237.135.camel@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 11:57:44AM +0100, Mike Galbraith wrote: > On Thu, 2015-05-28 at 10:49 +0100, Morten Rasmussen wrote: > > > Isn't sd == NULL is most cases if you don't move the sd assignment > > before the affine_sd assignment? > > sd will usually be NULL regardless of where the assignment is, as > SD_BALANCE_WAKE is usually off in ->flags. Josef is turning it on. Right. SD_BALANCE_WAKE needs to set in the sd flags and the assignment has to happen before the break for this to work. I just don't see SD_BALANCE_WAKE being enabled for the sched_domain anywhere in the patch?