From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932223AbbE1NDr (ORCPT ); Thu, 28 May 2015 09:03:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47098 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932176AbbE1NDi (ORCPT ); Thu, 28 May 2015 09:03:38 -0400 Date: Thu, 28 May 2015 15:03:24 +0200 From: Michal Hocko To: Wang Long Cc: akpm@linux-foundation.org, rientjes@google.com, vdavydov@parallels.com, hannes@cmpxchg.org, oleg@redhat.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wanglong@laoqinren.net, peifeiyue@huawei.com Subject: Re: [PATCH] OOM: print points as unsigned int Message-ID: <20150528130324.GD9540@dhcp22.suse.cz> References: <1432806404-223203-1-git-send-email-long.wanglong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432806404-223203-1-git-send-email-long.wanglong@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 28-05-15 09:46:44, Wang Long wrote: > In oom_kill_process(), the variable 'points' is unsigned int. > Print it as such. > > Signed-off-by: Wang Long I do not think this matter much in the real life but there is no reason to use a wrong format type. Acked-by: Michal Hocko Thanks! > --- > mm/oom_kill.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 2b665da..056002c 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -528,7 +528,7 @@ void oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order, > dump_header(p, gfp_mask, order, memcg, nodemask); > > task_lock(p); > - pr_err("%s: Kill process %d (%s) score %d or sacrifice child\n", > + pr_err("%s: Kill process %d (%s) score %u or sacrifice child\n", > message, task_pid_nr(p), p->comm, points); > task_unlock(p); > > -- > 1.8.3.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Michal Hocko SUSE Labs