From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754007AbbE1NxR (ORCPT ); Thu, 28 May 2015 09:53:17 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60612 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514AbbE1Nwx (ORCPT ); Thu, 28 May 2015 09:52:53 -0400 Date: Thu, 28 May 2015 14:52:45 +0100 From: Mark Brown To: Laxman Dewangan Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org, cfreeman@nvidia.com, abrestic@chromium.org Message-ID: <20150528135245.GU21577@sirena.org.uk> References: <1432737621-27590-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ap/ANiL3HUGlvZOJ" Content-Disposition: inline In-Reply-To: <1432737621-27590-1-git-send-email-ldewangan@nvidia.com> X-Cookie: Positively no smoking. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regulator: core: add support to get VSEL register from hw driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ap/ANiL3HUGlvZOJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 27, 2015 at 08:10:20PM +0530, Laxman Dewangan wrote: > Add callback on the regulator ops to get the voltage selection > register address and mask from device regulator driver. Use this > new callback in regulator_get_hardware_vsel_register(). It's not entirely clear to me that this is a good idea - the expected use case for getting the vsel register is to hand it off to something like a microcontroller for it to use but if the vsel register might change at runtime then we also need infrastructure to synchronize those changes with whatever is using the register. How does your system keep them in sync? --ap/ANiL3HUGlvZOJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZx2sAAoJECTWi3JdVIfQakQH/0AttUxGz8q5jKKat1yXGJtp 7mRuA4qsayi3IcpHcCNfLmau9NA7m40PLM+P10Itb2RVxmT87V1HDtH0HF1stFTY sDAQrKphn/tu8pC0h+jbTFKV/X442wU9rmcwcZqfFPAZ0sPFE7JLYDwayW91lJXp 3IJXttJpMslNJdT/HAC/isacxvauGb6VDP6zPUlkWwAj6yeHf4byt1NZmSbmrAiw 2QIL0T0dgxF/FAb5RN+AD6z/cpmIN1yKn+UGTyM5PFEiYsB8zAd44lrjUxe3TJz3 BUwef2ndZf6xk7MnoznYCog1qm+9mWhqCfS+XhOu4a69da5T2CLa59XTgtU0uZo= =ciRI -----END PGP SIGNATURE----- --ap/ANiL3HUGlvZOJ--