From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751332AbbE1N6I (ORCPT ); Thu, 28 May 2015 09:58:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60624 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487AbbE1N56 (ORCPT ); Thu, 28 May 2015 09:57:58 -0400 Date: Thu, 28 May 2015 14:57:51 +0100 From: Mark Brown To: Richard Fitzgerald Cc: patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20150528135751.GV21577@sirena.org.uk> References: <1432820714-31850-1-git-send-email-rf@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ypW9Hd+IdONQkcOt" Content-Disposition: inline In-Reply-To: <1432820714-31850-1-git-send-email-rf@opensource.wolfsonmicro.com> X-Cookie: Positively no smoking. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ypW9Hd+IdONQkcOt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 28, 2015 at 02:45:14PM +0100, Richard Fitzgerald wrote: > +#define ADSP2_SCRATCH0 0x40 > +#define ADSP2_SCRATCH1 0x41 > +#define ADSP2_SCRATCH2 0x42 > +#define ADSP2_SCRATCH3 0x43 May as well dump the other scratches while you're at it? > + unsigned int scratch1 = 0xFFFFFFFF; Why is this being initialized? > - adsp_dbg(dsp, "Shutdown complete\n"); > + adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1); That seems a bit loud for a diagnostic message, why raise the severity? --ypW9Hd+IdONQkcOt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZx7eAAoJECTWi3JdVIfQGCIH/iLgLHAVeiY8waIT/QCkNJWs M9NoaYwPP7rWu3PMYbTGqAyiWvJEBcaTeml8PrUtsECV5HlC0jPVjxEsaZ4JVNGj TBLOvPHVjqg3pQY6STt91c5eqwYma966sztqa1RUUv8vz8KdQYu/aJtoUHxfZuxo w3vDta05lNVgMcP9I8lgpJQURtm+C6JKNCWfj2qLFAbgv1kiYWvlMbT2aa3MVa9Q 5ysgD/CV44qRPhjKm1P+qL/G9klJwRc/OTYLnakjvEVJYKNEcEmx1VdCfMO8h5Xz vSO8P5Ag17J9O/GrU5ZRyWfQtDbW8JeUU4vRb7+i5Vij3bu4YhSwC/LiOVLKZVA= =PhVJ -----END PGP SIGNATURE----- --ypW9Hd+IdONQkcOt--