From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754063AbbE1Ohl (ORCPT ); Thu, 28 May 2015 10:37:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60723 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986AbbE1Ohd (ORCPT ); Thu, 28 May 2015 10:37:33 -0400 Date: Thu, 28 May 2015 15:37:24 +0100 From: Mark Brown To: Richard Fitzgerald Cc: patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-ID: <20150528143724.GY21577@sirena.org.uk> References: <1432820714-31850-1-git-send-email-rf@opensource.wolfsonmicro.com> <20150528135751.GV21577@sirena.org.uk> <20150528142431.GA19558@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6i9pF6wS+qS3ofr4" Content-Disposition: inline In-Reply-To: <20150528142431.GA19558@opensource.wolfsonmicro.com> X-Cookie: Positively no smoking. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6i9pF6wS+qS3ofr4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 28, 2015 at 03:24:39PM +0100, Richard Fitzgerald wrote: > On Thu, May 28, 2015 at 02:57:51PM +0100, Mark Brown wrote: > > > - adsp_dbg(dsp, "Shutdown complete\n"); > > > + adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1); > > That seems a bit loud for a diagnostic message, why raise the severity? > It's a diagnostic of the firmware, not the driver, and we can't assume that > people trying to use a firmware have the ability to build and flash a kernel > with a debug version of the driver The default is that dev_dbg() is available in dmesg but not on the console which usually seems like a reasonable balance for this sort of thing - it's there if people want it but not included in the default logging. --6i9pF6wS+qS3ofr4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVZygjAAoJECTWi3JdVIfQ/SYH/0wlkr2UVYm1AnE2qsEAK7zD /YEqw+yTjv9g2wB+dvKvqHSngRa+A+s8QvBabjklF/92kxYnNv4BIWpNqh0xigUe uPJMys+8+9b5yg9Vi4b6ea1eLrBi5IodF+mKO2op3RTKqxyRnOQmaQ4GLemTBBDk CQYUerMQpeQci2ZykYGrdKLU7+QPVEYB6FozZSrMoe7VPiLsK6KoBcWQ+HWU7MYO e6+iPAO8o8V3jQGvoOBi6+TUd1FtbC6PgtdQSlXoZ5eGKjcmjPaQPzvz0I8uc39q z6R2wGjnG/AUP8110s17TrPrA23/Z6BAszhM3mBanoPKnBoIsvydhh0Al2vb/Tc= =/sSc -----END PGP SIGNATURE----- --6i9pF6wS+qS3ofr4--