From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918AbbE1OZ3 (ORCPT ); Thu, 28 May 2015 10:25:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34808 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751676AbbE1OZW (ORCPT ); Thu, 28 May 2015 10:25:22 -0400 Date: Thu, 28 May 2015 16:25:18 +0200 From: Boris Brezillon To: Thierry Reding , linux-kernel@vger.kernel.org Cc: Boris Brezillon , dri-devel@lists.freedesktop.org, David Airlie , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni Subject: Re: [PATCH] drm: panel: simple-panel: set appropriate mode type Message-ID: <20150528162518.379f1714@bbrezillon> In-Reply-To: <1430404770-29704-1-git-send-email-boris.brezillon@free-electrons.com> References: <1430404770-29704-1-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, Could you have a look at this patch (a.k.a. ping) ? Best Regards, Boris On Thu, 30 Apr 2015 16:39:30 +0200 Boris Brezillon wrote: > All modes exposed by simple panels should be tagged as driver defined > modes. > Moreover, if a panel supports only one mode, this mode is obviously the > preferred one. > > Doing this also fix a problem occurring when a 'video=' parameter is passed > on the kernel cmdline. In some cases the user provided mode is preferred > over the simple panel ones, which might result in unpredictable behavior. > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/panel/panel-simple.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index d14b904..95ae390 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -111,6 +111,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel) > continue; > } > > + mode->type |= DRM_MODE_TYPE_DRIVER; > + if (panel->desc->num_modes == 1) > + mode->type |= DRM_MODE_TYPE_PREFERRED; > + > drm_display_mode_from_videomode(&vm, mode); > > drm_mode_probed_add(connector, mode); > @@ -127,6 +131,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel) > continue; > } > > + mode->type |= DRM_MODE_TYPE_DRIVER; > + if (panel->desc->num_modes == 1) > + mode->type |= DRM_MODE_TYPE_PREFERRED; > + > drm_mode_set_name(mode); > > drm_mode_probed_add(connector, mode); -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com