From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbbE1Q0Q (ORCPT ); Thu, 28 May 2015 12:26:16 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43663 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753530AbbE1Q0B (ORCPT ); Thu, 28 May 2015 12:26:01 -0400 X-Sasl-enc: h9T30Qg8BHq+XZ/KE5+ROChGQpzPl1VRmjXNBJYw7hds 1432830360 Date: Thu, 28 May 2015 09:25:54 -0700 From: Greg KH To: Xavier Roche Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones Message-ID: <20150528162554.GC23837@kroah.com> References: <1432826696-23001-1-git-send-email-roche@httrack.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432826696-23001-1-git-send-email-roche@httrack.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 05:24:56PM +0200, Xavier Roche wrote: > Local functions not used in other modules should be static, not extern. > (patch checked against linux-next and staging) This line shouldn't be here, it should just be "implied" :) > Signed-off-by: Xavier Roche > --- > drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) In the future, always use scripts/get_maintainer.pl to determine who to send patches to please. thanks, greg k-h