From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512AbbE1P6Z (ORCPT ); Thu, 28 May 2015 11:58:25 -0400 Received: from smtp205.alice.it ([82.57.200.101]:2599 "EHLO smtp205.alice.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754137AbbE1P6S (ORCPT ); Thu, 28 May 2015 11:58:18 -0400 Date: Thu, 28 May 2015 17:57:53 +0200 From: Antonio Ospite To: Irina Tirdea Cc: Dmitry Torokhov , Bastien Nocera , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9] input: goodix: fix variable length array warning Message-Id: <20150528175753.1f85723b5b880ecf02fd4a79@ao2.it> In-Reply-To: <1432817265-23891-3-git-send-email-irina.tirdea@intel.com> References: <1432817265-23891-1-git-send-email-irina.tirdea@intel.com> <1432817265-23891-3-git-send-email-irina.tirdea@intel.com> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) X-Face: z*RaLf`X<@C75u6Ig9}{oW$H;1_\2t5)({*|jhM/Vb;]yA5\I~93>J<_`<4)A{':UrE Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 May 2015 15:47:38 +0300 Irina Tirdea wrote: > Fix sparse warning: > drivers/input/touchscreen/goodix.c:182:26: warning: > Variable length array is used. > > Replace the variable length array with fixed length. > > Signed-off-by: Irina Tirdea > --- > drivers/input/touchscreen/goodix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > index c2e785c..dac1b3c 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -147,7 +147,7 @@ static void goodix_ts_report_touch(struct goodix_ts_data *ts, u8 *coor_data) > */ > static void goodix_process_events(struct goodix_ts_data *ts) > { > - u8 point_data[1 + GOODIX_CONTACT_SIZE * ts->max_touch_num]; > + u8 point_data[1 + GOODIX_CONTACT_SIZE * GOODIX_MAX_CONTACTS]; Hi, this fixes the warning from sparse, but also changes the semantics of the code: ts->max_touch_num is less that GOODIX_MAX_CONTACTS for 5 touches devices and in this case we'll end up using more memory than is necessary. Thanks, Antonio > int touch_num; > int i; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?