From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754530AbbE1Umb (ORCPT ); Thu, 28 May 2015 16:42:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58661 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbbE1UmY (ORCPT ); Thu, 28 May 2015 16:42:24 -0400 Date: Thu, 28 May 2015 13:42:17 -0700 From: Greg KH To: Arnd Bergmann Cc: Rachel Kim , Dean Lee , Chris Park , devel@driverdev.osuosl.org, nicolas.ferre@atmel.com, Johnny Kim , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: wilc1000 dead code removal Message-ID: <20150528204217.GA27387@kroah.com> References: <6776660.kcYzAMTBt8@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6776660.kcYzAMTBt8@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 10:23:35PM +0200, Arnd Bergmann wrote: > Subject: [PATCH] staging: wilc1000 dead code removal > > After finding some build errors in wilc1000, I played some more with > the driver and eliminated a lot of unused code. This is all code > meant for OS abstraction. Since we know we are running Linux, > and which version we use, it can all be removed. > > Some minor changes are included that are necessary to remove > other code. That's a lot of things all in one patch, I can't really review this. Any chance you can break it out into logical pieces that I can review? thanks, greg k-h