From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755438AbbE2IgH (ORCPT ); Fri, 29 May 2015 04:36:07 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:50662 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754337AbbE2If5 (ORCPT ); Fri, 29 May 2015 04:35:57 -0400 Date: Fri, 29 May 2015 09:35:41 +0100 From: Russell King - ARM Linux To: Eric Anholt Cc: linux-arm-kernel@lists.infradead.org, Ulf Hansson , Stephen Warren , Lee Jones , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH] mmc: sdhci-bcm2835: Actually enable the clock Message-ID: <20150529083541.GH2067@n2100.arm.linux.org.uk> References: <1432857792-7421-1-git-send-email-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432857792-7421-1-git-send-email-eric@anholt.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2015 at 05:03:12PM -0700, Eric Anholt wrote: > We're currently using a fixed frequency clock specified in the DT, so > enabling is a no-op. However, the RPi firmware-based clocks driver > can actually disable unused clocks, so when switching to use it we > ended up losing our MMC clock once all devices were probed. > > Signed-off-by: Eric Anholt > --- > drivers/mmc/host/sdhci-bcm2835.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c > index 0ef0343..09aff3a 100644 > --- a/drivers/mmc/host/sdhci-bcm2835.c > +++ b/drivers/mmc/host/sdhci-bcm2835.c > @@ -172,6 +172,11 @@ static int bcm2835_sdhci_probe(struct platform_device *pdev) > ret = PTR_ERR(pltfm_host->clk); > goto err; > } > + ret = clk_prepare_enable(pltfm_host->clk); > + if (ret) { > + dev_err(&pdev->dev, "failed to enable host clk\n"); > + goto err; > + } > > return sdhci_add_host(host); Where's the error clean-up path for a failed sdhci_add_host()? -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.