From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755726AbbE2Jsz (ORCPT ); Fri, 29 May 2015 05:48:55 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:52278 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624AbbE2Jsq (ORCPT ); Fri, 29 May 2015 05:48:46 -0400 Date: Fri, 29 May 2015 15:15:47 +0530 From: "Naveen N. Rao" To: Ingo Molnar Cc: Balbir Singh , "linux-kernel@vger.kernel.org" , Peter Zijlstra , srikar@linux.vnet.ibm.com Subject: Re: [PATCH] proc/schedstat: Expose /proc//schedstat if delay accounting is enabled Message-ID: <20150529094547.GE17421@naverao1-tp.ibm.com> References: <1432537954-26665-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com> <20150529061620.GA17421@naverao1-tp.ibm.com> <20150529080424.GA27235@gmail.com> <20150529085504.GD17421@naverao1-tp.ibm.com> <20150529091837.GA30451@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529091837.GA30451@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052909-0013-0000-0000-0000015B3A27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/05/29 11:18AM, Ingo Molnar wrote: > > * Naveen N. Rao wrote: > > > On 2015/05/29 10:04AM, Ingo Molnar wrote: > > > > > > * Naveen N. Rao wrote: > > > > > > - The sum_exec_runtime field is available unconditionally. > > > > > > - But the sched_info.run_delay field is only maintained if CONFIG_SCHEDSTATS is > > > enabled. > > > > > > - Also, the sched_info.pcount field is again only maintained if CONFIG_SCHEDSTATS > > > is enabled. > > > > I may be missing something, but from my reading of the code, the above > > are maintained if any one of CONFIG_SCHEDSTATS or CONFIG_TASK_DELAY_ACCT > > are enabled (from kernel/sched/stats.h). > > Hm, indeed - I mis-read the rq-specific code - sorry. > > So all this should really be cleaned up: > > include/linux/sched.h:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT) > include/linux/sched.h:#endif /* defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT) */ > include/linux/sched.h:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT) > kernel/sched/core.c:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT) > kernel/sched/stats.h:#if defined(CONFIG_SCHEDSTATS) || defined(CONFIG_TASK_DELAY_ACCT) > kernel/sched/stats.h:#endif /* CONFIG_SCHEDSTATS || CONFIG_TASK_DELAY_ACCT */ > > by introducing an intermediate Kconfig variable, named CONFIG_SCHED_INFO or so, > and selected by both SCHEDSTATS and TASK_DELAY_ACCT. > > Please make it two patches: the first one adds CONFIG_SCHED_INFO and cleans up the > code to use it, the second one uses it for the procps change. Sure, will do. On a related note, even though sum_exec_runtime is available unconditionally, I dump all zeroes in my patch if !sched_info_on() to make it clear that some of the fields are not available. Is this ok or should be display sum_exec_runtime regardless of sched_info? Thanks, Naveen