From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755946AbbE2MCH (ORCPT ); Fri, 29 May 2015 08:02:07 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:47148 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754870AbbE2MB6 (ORCPT ); Fri, 29 May 2015 08:01:58 -0400 Date: Fri, 29 May 2015 14:01:51 +0200 From: Michael Holzheu To: Nicholas Mc Guire Cc: Heiko Carstens , Nicholas Mc Guire , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] s390/sclp: pass timeout as HZ independent value Message-ID: <20150529140151.2846c257@holzheu> In-Reply-To: <20150529114936.GA21897@opentech.at> References: <1432746283-8068-1-git-send-email-hofrat@osadl.org> <20150529090715.GA4169@osiris> <20150529095154.GB9952@opentech.at> <20150529103523.GB4169@osiris> <20150529114936.GA21897@opentech.at> Organization: IBM X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052912-0021-0000-0000-00000415DFBB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 May 2015 13:49:36 +0200 Nicholas Mc Guire wrote: > On Fri, 29 May 2015, Heiko Carstens wrote: > > > On Fri, May 29, 2015 at 11:51:54AM +0200, Nicholas Mc Guire wrote: > > > On Fri, 29 May 2015, Heiko Carstens wrote: > > > > Yes, the orginal code seems to be broken. Since I've no idea what the intended > > > > timeout value should be, let's simply ask Michael, who wrote this code eight > > > > years ago ;) > > > > While these lines get touched anyway, it would make sense to use > > > > schedule_timeout_interruptible() instead, and get rid of set_current_state(). > > > > > > > Well that is not really equivalent > > > schedule_timeout_interruptible() is doing > > > __set_current_state not set_current_state > > > so that would drop the mb() and no WRITE_ONCE() > > > > And how does that matter in this case? > > > I do not know - did not look into it - in any case > its not a 1:1 API consolidation that all I wanted to point out > before changing anything. I agree, 1:1 consolidation is better here. But I would like to remove the SDIAS_SLEEP_TICKS define and just use HZ / 2 in schedule_timeout(). Could you please resend the updated patch? We will then add it to our tree. Thanks Michael