From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757508AbbE3Ftj (ORCPT ); Sat, 30 May 2015 01:49:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:36012 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbbE3Ftb (ORCPT ); Sat, 30 May 2015 01:49:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,521,1427785200"; d="scan'208";a="734068931" Date: Fri, 29 May 2015 22:49:27 -0700 From: Andi Kleen To: Jiri Olsa Cc: Sukadev Bhattiprolu , mingo@redhat.com, Michael Ellerman , Arnaldo Carvalho de Melo , Paul Mackerras , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/10] perf, tools: Handle header line in mapfile Message-ID: <20150530054927.GB1187@tassilo.jf.intel.com> References: <1432761809-4344-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432761809-4344-5-git-send-email-sukadev@linux.vnet.ibm.com> <20150528124221.GK12392@krava.redhat.com> <20150529054506.GA3088@us.ibm.com> <20150529091140.GA20512@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150529091140.GA20512@krava.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2015 at 11:13:15AM +0200, Jiri Olsa wrote: > On Thu, May 28, 2015 at 10:45:06PM -0700, Sukadev Bhattiprolu wrote: > > Jiri Olsa [jolsa@redhat.com] wrote: > > | > if (line[0] == '#' || line[0] == '\n') > > | > continue; > > | > + if (!strncmp(line, "Family", 6)) > > | > + continue; > > | > > | I think we should fix mapfiles to put the 'Family' starting > > | line as a comment.. the way powerpc mapfile is done > > > > You mean add something like this to the Intel mapfile: > > > > # Power8 entries > > 004d0100,1,power8.json,core > > > > and drop this patch? > > right But it's a CSV file. CSV files are supposed to have column headers. There are lots of tools that work better with them if they have headers. Please keep the header. -Andi -- ak@linux.intel.com -- Speaking for myself only