From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757943AbbEaDZA (ORCPT ); Sat, 30 May 2015 23:25:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39865 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757753AbbEaDYu (ORCPT ); Sat, 30 May 2015 23:24:50 -0400 Date: Sun, 31 May 2015 12:23:53 +0900 From: Greg Kroah-Hartman To: Michal Simek Cc: Shailendra Verma , =?iso-8859-1?Q?S=F6ren?= Brinkmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration(). Message-ID: <20150531032353.GB1603@kroah.com> References: <1432582863-5012-1-git-send-email-shailendra.capricorn@gmail.com> <5565B9B7.8080506@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5565B9B7.8080506@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2015 at 02:33:59PM +0200, Michal Simek wrote: > +Greg > > On 05/25/2015 09:41 PM, Shailendra Verma wrote: > > The variable dirty is bool type. Hence assign the variable with > > bool value true/false instead of 1/0. > > > > Signed-off-by: Shailendra Verma > > --- > > drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c > > index 05d8977..53c3882 100644 > > --- a/drivers/char/xilinx_hwicap/buffer_icap.c > > +++ b/drivers/char/xilinx_hwicap/buffer_icap.c > > @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data, > > int status; > > s32 buffer_count = 0; > > s32 num_writes = 0; > > - bool dirty = 0; > > + bool dirty = false; > > u32 i; > > void __iomem *base_address = drvdata->base_address; > > > > @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data, > > > > /* Copy data to bram */ > > buffer_icap_set_bram(base_address, buffer_count, data[i]); > > - dirty = 1; > > + dirty = true; > > > > if (buffer_count < XHI_MAX_BUFFER_INTS - 1) { > > buffer_count++; > > @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data, > > > > buffer_count = 0; > > num_writes++; > > - dirty = 0; > > + dirty = false; > > } > > > > /* Write unwritten data to ICAP */ > > > > Tested-by: Michal Simek Hm, I don't have the original, can you resend it with your tested-by? thanks, greg k-h